From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8367017F4FD for ; Tue, 25 Jun 2024 23:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719359366; cv=none; b=A0+LqnpmUtmBl7kQVHhBoUq4Asx0IzuWHhyHCqTg2e3VI03lErORC1L/otClMFS6QlK+t+AMyInVQNCrl2RqczPPM+ym8IuJwa1N9pXtTGQturun9QMBR1yKK/7+QUXx/19VEhuCwLBmGSyk9NiCiVORVjOcsvKKj+mSOr971lo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719359366; c=relaxed/simple; bh=2ZFq/h/cdDU27DXX0AmZ/Rf/mFbsafxBM9Z04LggrFU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n7bZ0L4MnVgm38uMa1z/c/jr6WrMryzbHvuXgwwv6Pz/bDuBSnclqeRdY3+1zTnkWWn5USCOMxpc5Y5SIRwKeA4xC4/BWrikMoxRnyjwEHKEmdkfuQHW8Vp0VWij4IcI6F/osAdxB6fS3Oo2O4PQo0+wl7qG4K+eGzPYVtvmwBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GVJ1oPak; arc=none smtp.client-ip=209.85.221.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GVJ1oPak" Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-363bd55bcc2so4869821f8f.2 for ; Tue, 25 Jun 2024 16:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719359363; x=1719964163; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VOxs9q/KRWV6ovXgAREtQ7mXRlDPaMH/Kc3byJkLH+o=; b=GVJ1oPakpgne40Ae/T+aVqhJx71YOugP6H2+3Nn17d8cN+rJee3TcmEfyn3cPNYLNU HCygAcdj2CnXu0ptY3b/a7xcBXylJOplqblrrIYWGc8p2boE6SUru8VZNwdDeu8nLjlU 4W9r4CK8p7VxBI661+1CLFmmFVDRnvOGKDJD9xqq2WaTtHS49mKDmUvwbeEXqo0/R/GY a7TBFL/m5taAYU/aGQN3oXS4ULEZBSIdolrSOpaqCSaUKdaGs2ys4VWv2mqv3dazOlho WSaHVtN6in1ePDDNbw+OlWMaWb0F3lgVfXpKJetdPsM2zVoG4CHBWPMtGHnnaN6VTpqL fj1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719359363; x=1719964163; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VOxs9q/KRWV6ovXgAREtQ7mXRlDPaMH/Kc3byJkLH+o=; b=pgPtnh+0xcYbGEA8FV5mKn2pdHaWhlef2Bbtesn+0yAfby6OeeYHQKw0Hs7Fy7hBRw uGWHMj/A4sMiHBB7vfhxkJE2bHhSjYOZhAG5c9QIbk8QkDg/387D9N1AHG7wJa2zsj0R 4PyGeC8FjCTGhFz1gV0y7uf9ah43+ydKKEER8Tf/UPUc7CXJ2ShGhewT4pMPAqgEu6do WZBQ16V/RNfQBA0NrIYIuiBiecgIXEf0llp60JZY94k9p5EUEpF7nXA/aJK2WqZTfW2j VyNaKf9tjtIgaeyabK8O9LuYINPhWGV6FaJoLDTUJEVbOegckJxcdqMBpZbTxwmo7BBt 7SMQ== X-Forwarded-Encrypted: i=1; AJvYcCVfzT/t1/mHWXLBIDSLTJTtgJL9a1f4mhMTVjVCMmorUoSjuKPdA/vAZdpRbmJjw/B6FzmSWiRaQrQVUqf4LSwSs0/gjf8X7vdSww== X-Gm-Message-State: AOJu0YxiGdwvuXQMlyITQjwhUU2Cn8h5yAT+xuFNeSPTuOcsurj+5ycF 7WLk8wWDJ0Eg0vvBd3VEP6S48BYiGDgMx7vEReT7QBwBzk4/pstcwJIfNVRG0ro= X-Google-Smtp-Source: AGHT+IE300h3oYgIh4+YcZq9y1SiitbL6hkufbwWeabZwmZQrEHKJL1469s/fCZ0jlsaVjC07ffmXw== X-Received: by 2002:a5d:4a0f:0:b0:360:8e71:627f with SMTP id ffacd0b85a97d-366e962fb68mr5516528f8f.59.1719359362915; Tue, 25 Jun 2024 16:49:22 -0700 (PDT) Received: from [192.168.0.16] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3663a8c789esm14227767f8f.91.2024.06.25.16.49.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 16:49:22 -0700 (PDT) Message-ID: <47997e61-26e5-4643-ac69-17db09be9bb1@linaro.org> Date: Wed, 26 Jun 2024 00:49:53 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT v3 5/5] arm64: dts: qcom: sc7180: camss: Add CAMSS block definition To: gchan9527@gmail.com, Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240624-b4-sc7180-camss-v3-0-89ece6471431@gmail.com> <20240624-b4-sc7180-camss-v3-5-89ece6471431@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240624-b4-sc7180-camss-v3-5-89ece6471431@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/06/2024 13:13, George Chan via B4 Relay wrote: > From: George Chan > > Introduce camss subsys support to sc7180 family soc. > > Signed-off-by: George Chan This looks fine to me. Where is the CCI and sensor stuff - could you post a link to your working kernel tree in your next cover letter ? i.e. I see the clean kernel tree https://github.com/torvalds/linux/compare/master...99degree:linux:camss but it'd be nice to see the tree with the sensor wired up too Reviewed-by: Bryan O'Donoghue