From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
William-tw Lin <william-tw.lin@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3 2/3] soc: mediatek: mtk-socinfo: Add driver for getting chip information
Date: Wed, 20 Dec 2023 14:13:51 +0100 [thread overview]
Message-ID: <479fa717-8de7-4f1b-b02c-2cfbd49f71cc@collabora.com> (raw)
In-Reply-To: <97d54894-7c71-49d8-a456-869c398636ec@linaro.org>
Il 20/12/23 12:34, Krzysztof Kozlowski ha scritto:
> On 20/12/2023 11:39, William-tw Lin wrote:
>> Add driver for socinfo retrieval. This patch includes the following:
>> 1. mtk-socinfo driver for chip info retrieval
>> 2. Related changes to Makefile and Kconfig
>>
>> Signed-off-by: William-tw Lin <william-tw.lin@mediatek.com>
>
> ...
>
>> +static struct platform_driver mtk_socinfo = {
>> + .probe = mtk_socinfo_probe,
>> + .remove_new = mtk_socinfo_remove,
>> + .driver = {
>> + .name = "mtk-socinfo",
>> + },
>> +};
>> +builtin_platform_driver(mtk_socinfo);
>
> module platform driver, because this is tristate and because this should
> be a module.
>
Oh! Yes, right! Thanks for catching that, it totally slipped off my brain.
Cheers,
Angelo
next prev parent reply other threads:[~2023-12-20 13:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 10:38 [PATCH v3 0/3] mtk-socinfo driver implementation William-tw Lin
2023-12-20 10:38 ` [PATCH v3 1/3] arm64: dts: Add node for chip info driver William-tw Lin
2023-12-20 11:02 ` AngeloGioacchino Del Regno
2023-12-20 10:39 ` [PATCH v3 2/3] soc: mediatek: mtk-socinfo: Add driver for getting chip information William-tw Lin
2023-12-20 10:53 ` AngeloGioacchino Del Regno
2023-12-22 8:03 ` William-tw Lin (林鼎崴)
2023-12-20 11:34 ` Krzysztof Kozlowski
2023-12-20 13:13 ` AngeloGioacchino Del Regno [this message]
2023-12-22 8:03 ` William-tw Lin (林鼎崴)
2023-12-20 10:39 ` [PATCH v3 3/3] nvmem: mtk-efuse: Modify " William-tw Lin
2023-12-20 11:02 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479fa717-8de7-4f1b-b02c-2cfbd49f71cc@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=william-tw.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).