From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [PATCH] of: treat PCI config space as IORESOURCE_MEM type Date: Thu, 29 May 2014 15:51:28 -0500 Message-ID: <47B1E3D0-4336-4529-80B0-172F4ACA5C97@codeaurora.org> References: <1401379426-9701-1-git-send-email-galak@codeaurora.org> Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Rob Herring , Grant Likely , Pawel Moll , Mark Rutland , Ian Campbell , Bjorn Helgaas , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , linux-arm-msm , "linux-arm-kernel@lists.infradead.org" , Liviu Dudau , Kishon Vijay Abraham I List-Id: devicetree@vger.kernel.org On May 29, 2014, at 3:44 PM, Rob Herring wrote: > On Thu, May 29, 2014 at 11:03 AM, Kumar Gala wrote: >> If we have a PCI config space specified in something like a ranges >> property we should treat it as memory type resource. > > Config space should not be in ranges[1]. We have some cases that are, > but we don't want new ones. For the cases we have I agree, however an ECAM based cfg seems completely legit. >> Signed-off-by: Kumar Gala >> --- >> drivers/of/address.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/of/address.c b/drivers/of/address.c >> index cb4242a..4e7ee59 100644 >> --- a/drivers/of/address.c >> +++ b/drivers/of/address.c >> @@ -122,6 +122,9 @@ static unsigned int of_bus_pci_get_flags(const __be32 *addr) >> u32 w = be32_to_cpup(addr); >> >> switch((w >> 24) & 0x03) { >> + case 0x00: /* cfg space */ >> + flags |= IORESOURCE_MEM; >> + break; > > How would you then distinguish actual memory ranges? One assumes you are still looking at pci_space as part of of_pci_range > > Rob > > [1] http://www.spinics.net/lists/linux-pci/msg30585.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation