From: Florian Fainelli <f.fainelli@gmail.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Jeremy Linton <jeremy.linton@arm.com>,
Andrew Murray <andrew.murray@arm.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: james.quinlan@broadcom.com, mbrugger@suse.com,
phil@raspberrypi.org, wahrenst@gmx.net,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] PCI: brcmstb: add Broadcom STB PCIe host controller driver
Date: Mon, 11 Nov 2019 08:40:17 -0800 [thread overview]
Message-ID: <47a9aa83-c385-821e-170a-061afd2bdc9a@gmail.com> (raw)
In-Reply-To: <94213d9b5fa2b4916bcada49ff938e394f0c859e.camel@suse.de>
On 11/11/19 7:29 AM, Nicolas Saenz Julienne wrote:
> Hi Jeremy,
> thanks for the review.
>
> On Mon, 2019-11-11 at 01:10 -0600, Jeremy Linton wrote:
[snip]
>>> +static const int pcie_offset_bcm2711[] = {
>>> + [RGR1_SW_INIT_1] = 0x9210,
>>> + [EXT_CFG_INDEX] = 0x9000,
>>> + [EXT_CFG_DATA] = 0x8000,
>>> +};
>>
>> Given that there is currently only a single set of register offsets,
>> this seems like it could be simpler.
>
> You're right, there is no need for it as of this series. But since we know
> we'll be supporting other SoCs in the near future I figured it was harmless to
> leave this as a dt dependent config.
I would rather leave it as is right now because while possibly
inefficient, adding a later series whose purpose is to add register
indirection would just clutter the review process IMHO, the way it is
right now does not hurt.
(please trim your replies to remove what you are not responding to).
--
Florian
next prev parent reply other threads:[~2019-11-11 16:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 21:45 [PATCH 0/4] Raspberry Pi 4 PCIe support Nicolas Saenz Julienne
2019-11-06 21:45 ` [PATCH 1/4] dt-bindings: pci: add bindings for brcmstb's PCIe device Nicolas Saenz Julienne
2019-11-07 10:32 ` Andrew Murray
2019-11-07 10:53 ` Nicolas Saenz Julienne
2019-11-13 4:15 ` Rob Herring
2019-11-14 13:15 ` Nicolas Saenz Julienne
2019-11-06 21:45 ` [PATCH 2/4] ARM: dts: bcm2711: Enable PCIe controller Nicolas Saenz Julienne
2019-11-07 10:37 ` Andrew Murray
2019-11-12 9:18 ` Nicolas Saenz Julienne
2019-11-07 17:44 ` Stefan Wahren
2019-11-07 18:24 ` Nicolas Saenz Julienne
2019-11-06 21:45 ` [PATCH 3/4] PCI: brcmstb: add Broadcom STB PCIe host controller driver Nicolas Saenz Julienne
2019-11-07 15:00 ` Andrew Murray
2019-11-07 16:12 ` Jim Quinlan
2019-11-08 10:52 ` Andrew Murray
2019-11-08 16:33 ` Jim Quinlan
2019-11-07 17:30 ` Nicolas Saenz Julienne
2019-11-08 10:51 ` Andrew Murray
2019-11-07 17:50 ` Stefan Wahren
2019-11-08 11:13 ` Nicolas Saenz Julienne
2019-11-11 7:10 ` Jeremy Linton
2019-11-11 15:29 ` Nicolas Saenz Julienne
2019-11-11 16:40 ` Florian Fainelli [this message]
2019-11-11 20:00 ` Jeremy Linton
2019-11-11 21:27 ` Florian Fainelli
2019-11-06 21:45 ` [PATCH 4/4] PCI: brcmstb: add MSI capability Nicolas Saenz Julienne
2019-11-07 15:40 ` Marc Zyngier
2019-11-11 11:21 ` Nicolas Saenz Julienne
2019-11-11 13:29 ` Marc Zyngier
2019-11-06 21:51 ` [PATCH 0/4] Raspberry Pi 4 PCIe support Florian Fainelli
2019-11-07 9:58 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47a9aa83-c385-821e-170a-061afd2bdc9a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew.murray@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=james.quinlan@broadcom.com \
--cc=jeremy.linton@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mbrugger@suse.com \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).