devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm8350: add missing core_bi_pll_test_se GCC clock
Date: Wed, 28 Dec 2022 16:34:56 +0200	[thread overview]
Message-ID: <47bb59f1-c696-5be3-cc6e-f82f5ee0998e@linaro.org> (raw)
In-Reply-To: <279dc76c-9e60-dd93-e2d2-c2dad241620f@linaro.org>

On 28/12/2022 16:25, Krzysztof Kozlowski wrote:
> On 28/12/2022 13:50, Dmitry Baryshkov wrote:
>> On 28/12/2022 13:55, Krzysztof Kozlowski wrote:
>>> On 28/12/2022 12:37, Konrad Dybcio wrote:
>>>>
>>>>
>>>> On 28.12.2022 12:24, Krzysztof Kozlowski wrote:
>>>>> The GCC bindings expect core_bi_pll_test_se clock input, even if it is
>>>>> optional:
>>>>>
>>>>>     sm8350-mtp.dtb: clock-controller@100000: clock-names:2: 'core_bi_pll_test_se' was expected
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>> ---
>>>> Is it even going to be used by anybody, or should we just drop
>>>> it on the driver side as per usual?
>>>
>>> It's mentioned as possible parent, so there might be users somewhere...
>>> Or you want to say that other binding and DTS users cannot use that clock?
>>
>> Yes. In the past few months we have been removing the core_bi_pll_test
>> from the old clock drivers (and new clock drivers mostly lack them).
>> Let's remove it from the rest of clock drivers.
> 
> If you are going to start doing the same work, please at least share it
> upfront.

Excuse me.

-- 
With best wishes
Dmitry


  reply	other threads:[~2022-12-28 14:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-28 11:24 [PATCH 1/2] arm64: dts: qcom: sm8350: add missing core_bi_pll_test_se GCC clock Krzysztof Kozlowski
2022-12-28 11:24 ` [PATCH 2/2] arm64: dts: qcom: sm8350-sony-xperia-sagami: specify which LDO modes are allowed Krzysztof Kozlowski
2022-12-28 11:37 ` [PATCH 1/2] arm64: dts: qcom: sm8350: add missing core_bi_pll_test_se GCC clock Konrad Dybcio
2022-12-28 11:55   ` Krzysztof Kozlowski
2022-12-28 12:26     ` Konrad Dybcio
2022-12-28 12:50     ` Dmitry Baryshkov
2022-12-28 14:25       ` Krzysztof Kozlowski
2022-12-28 14:34         ` Dmitry Baryshkov [this message]
2022-12-29 17:23 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47bb59f1-c696-5be3-cc6e-f82f5ee0998e@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).