Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Stephan Gerhold <stephan.gerhold@linaro.org>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] mtd: rawnand: qcom: Add MDM9607
Date: Mon, 6 Jul 2026 18:18:15 +0200	[thread overview]
Message-ID: <47bd85c0-f015-4c43-b616-c249596d7537@kernel.org> (raw)
In-Reply-To: <spaihty2s3zfj7jsv63ex7elf3bwz3bbak5ubageusatdgiodd@qh5gfhhh5ppo>

On 06/07/2026 18:00, Manivannan Sadhasivam wrote:
> On Mon, Jul 06, 2026 at 04:42:21PM +0200, Miquel Raynal wrote:
> 
>>> and if the driver queries the frequency of
>>> RPM_SMD_QPIC_CLK, it would just return the same frequency. This is where the
>>> dummy clock comes handy as it atleast provides a valid clock frequency to the
>>> driver. But I'm not advocating for its usage here anymore.
>>>
>>> Hence IMO, assigning the same RPM_SMD_QPIC_CLK to all 3 clocks is not the right
>>> approach and we should be assigning a single RPM_SMD_QPIC_CLK to
>>> 'core' clk.
>>
>> You said using three times the same clock would be wrong because we
>> would get three times the same rate whereas in practice it's wrong. This
>> means the OS has access to these clocks somehow,
> 
> No, there is no way the OS can access these 3 clocks individually on the RPMh
> enabled platforms. But the OS indeed has access to these 3 clocks on non-RPMh
> platforms like the older IPQ ones.

I think RPMh is a bit different case than recently discussed SCMI
firmware layer, although maybe the true difference is irrelevant -
whoever implements the clock handling, it is not Linux. Anyway, in case
of SCMI this is the same die having either firmware or OS controlling
clocks.

Here the SoCs (IPO ones without RPMh and this one with RPMh) are different.

If this was some bus device (I2C, SPI etc), then I would argue that the
device pins matter.

However this is internal part of the SoC, so while it still has some
wirings, they are heavily hidden or abstracted, thus I am fine with
approach that clocks represent the clock interfaces available to the OS,
not the physical wires inside SoC.


Best regards,
Krzysztof

      parent reply	other threads:[~2026-07-06 16:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08 13:20 [PATCH 0/4] mtd: rawnand: qcom: Add MDM9607 Stephan Gerhold
2026-06-08 13:20 ` [PATCH 1/4] dt-bindings: mtd: qcom,nandc: Add MDM9607 QPIC NAND controller Stephan Gerhold
2026-06-09  7:19   ` Krzysztof Kozlowski
2026-06-09  7:52     ` Miquel Raynal
2026-06-09  8:10       ` Stephan Gerhold
2026-06-09  8:55         ` Konrad Dybcio
2026-06-09  9:01           ` Konrad Dybcio
2026-06-09  9:08             ` Stephan Gerhold
2026-06-09  9:30               ` Miquel Raynal
2026-06-09 10:02                 ` Stephan Gerhold
2026-06-17 11:42                   ` Konrad Dybcio
2026-06-29 15:06                     ` Miquel Raynal
2026-06-29 15:45                     ` Manivannan Sadhasivam
2026-06-08 13:20 ` [PATCH 2/4] mtd: rawnand: qcom: Make "aon" clock optional Stephan Gerhold
2026-06-08 13:30   ` sashiko-bot
2026-06-09  7:24   ` Krzysztof Kozlowski
2026-06-08 13:20 ` [PATCH 3/4] mtd: rawnand: qcom: Make has_onfi_read_op separate from qpic_version2 Stephan Gerhold
2026-06-08 13:34   ` sashiko-bot
2026-06-08 13:20 ` [PATCH 4/4] mtd: rawnand: qcom: Add MDM9607 compatible Stephan Gerhold
2026-06-29 15:46 ` [PATCH 0/4] mtd: rawnand: qcom: Add MDM9607 Manivannan Sadhasivam
2026-07-06 12:55   ` Stephan Gerhold
2026-07-06 13:18     ` Miquel Raynal
2026-07-06 13:26       ` Stephan Gerhold
2026-07-06 14:19         ` Manivannan Sadhasivam
2026-07-06 14:42           ` Miquel Raynal
2026-07-06 16:00             ` Manivannan Sadhasivam
2026-07-06 16:13               ` Miquel Raynal
2026-07-06 16:18               ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47bd85c0-f015-4c43-b616-c249596d7537@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=stephan.gerhold@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox