devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Denzeel Oliva <wachiturroxd150@gmail.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/4] clk: samsung: exynos990: update CLK_NR_TOP for new IDs clocks
Date: Sat, 30 Aug 2025 11:18:14 +0200	[thread overview]
Message-ID: <47ddc58b-02d6-42e7-83f8-09bb80d73894@kernel.org> (raw)
In-Reply-To: <20250825-cmu-top-v4-3-71d783680529@gmail.com>

On 25/08/2025 07:51, Denzeel Oliva wrote:
> The new clock IDs have been added and put last,
> it is necessary to change.
> 
> Signed-off-by: Denzeel Oliva <wachiturroxd150@gmail.com>
> ---
>  drivers/clk/samsung/clk-exynos990.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos990.c b/drivers/clk/samsung/clk-exynos990.c
> index 105ba0363..9fcdad7cc 100644
> --- a/drivers/clk/samsung/clk-exynos990.c
> +++ b/drivers/clk/samsung/clk-exynos990.c
> @@ -17,7 +17,7 @@
>  #include "clk-pll.h"
>  
>  /* NOTE: Must be equal to the last clock ID increased by one */
> -#define CLKS_NR_TOP (CLK_GOUT_CMU_VRA_BUS + 1)
> +#define CLKS_NR_TOP (CLK_DOUT_CMU_CLK_CMUREF + 1)

This belongs to the driver patch introducing these new clocks. Such
change alone makes no sense or commit msg really does not explain issue
being fixed here.

Best regards,
Krzysztof

  reply	other threads:[~2025-08-30  9:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25  5:51 [PATCH v4 0/4] clk: samsung: exynos990: CMU_TOP fixes (mux regs, widths, factors) Denzeel Oliva
2025-08-25  5:51 ` [PATCH v4 1/4] clk: samsung: exynos990: Fix CMU TOP mux/div widths and add fixed-factors Denzeel Oliva
2025-08-30  9:17   ` Krzysztof Kozlowski
2025-08-25  5:51 ` [PATCH v4 2/4] dt-bindings: clock: exynos990: Extend clocks IDs Denzeel Oliva
2025-08-29 15:26   ` Rob Herring (Arm)
2025-08-25  5:51 ` [PATCH v4 3/4] clk: samsung: exynos990: update CLK_NR_TOP for new IDs clocks Denzeel Oliva
2025-08-30  9:18   ` Krzysztof Kozlowski [this message]
2025-08-25  5:51 ` [PATCH v4 4/4] clk: samsung: exynos990: Fix PLL mux regs, add DPU/CMUREF Denzeel Oliva
2025-08-30  9:16   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47ddc58b-02d6-42e7-83f8-09bb80d73894@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=wachiturroxd150@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).