From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Caleb Connolly <caleb.connolly@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
phone-devel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v7 1/2] power: supply: add Qualcomm PMI8998 SMB2 Charger driver
Date: Sun, 29 Jan 2023 21:35:46 +0100 [thread overview]
Message-ID: <47ee24cd-4239-772b-6dc6-d0741e813f15@linaro.org> (raw)
In-Reply-To: <20230129202043.w6mylxeccz2fyxl2@mercury.elektranox.org>
On 29/01/2023 21:20, Sebastian Reichel wrote:
> Hi,
>
> I tried applying this, but it generates a compiler warning:
>
> On Fri, Jan 27, 2023 at 11:05:05PM +0000, Caleb Connolly wrote:
>> [...]
>> +static int smb2_probe(struct platform_device *pdev)
>> +{
>> [...]
>> + desc->name = devm_kasprintf(chip->dev, GFP_KERNEL, "%s-charger",
>> + device_get_match_data(chip->dev));
>
> drivers/power/supply/qcom_pmi8998_charger.c: In function ‘smb2_probe’:
> drivers/power/supply/qcom_pmi8998_charger.c:979:62: warning: format ‘%s’ expects argument of type ‘char *’, but argument 4 has type ‘const void *’ [-Wformat=]
> 979 | desc->name = devm_kasprintf(chip->dev, GFP_KERNEL, "%s-charger",
> | ~^
> | |
> | char *
> | %p
> 980 | device_get_match_data(chip->dev));
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | const void *
This was also reported now by kernel test robot. I wonder why there were
no earlier reports...
Best regards,
Krzysztof
prev parent reply other threads:[~2023-01-29 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 23:05 [PATCH v7 1/2] power: supply: add Qualcomm PMI8998 SMB2 Charger driver Caleb Connolly
2023-01-27 23:05 ` [PATCH v7 2/2] dt-bindings: power: supply: qcom,pmi8998-charger: add bindings for smb2 driver Caleb Connolly
2023-01-29 19:00 ` [PATCH v7 1/2] power: supply: add Qualcomm PMI8998 SMB2 Charger driver kernel test robot
2023-01-29 20:20 ` Sebastian Reichel
2023-01-29 20:35 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ee24cd-4239-772b-6dc6-d0741e813f15@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).