From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33667C61D97 for ; Sun, 29 Jan 2023 20:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232549AbjA2Ufz (ORCPT ); Sun, 29 Jan 2023 15:35:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230365AbjA2Ufy (ORCPT ); Sun, 29 Jan 2023 15:35:54 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EE4018B2F for ; Sun, 29 Jan 2023 12:35:51 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id h16so9316704wrz.12 for ; Sun, 29 Jan 2023 12:35:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j8aqki5CcPtcLzfCY7Wo7lQT4J4ibEQGFMyeTxDiGAQ=; b=OZbq6tnzL8TeplhGciC1YL9kquoVfH5YeTYjfDIHV2BoCrfBcqQ1q/vIXUwCcoMDjJ pqDgytiooxv2G1ZkM02XtHEAQ0oshsEFq6ZK6JmzfORnilUVjG4H1cIWStj2wn/xBFqP S/2gIwfobAtjdt44Wb6Dyo6OhcWj8NjoxLr3ZbH5MLvjNbye3Sbvf6+UrRsBDGitvBp0 Ajp895PriLJw8dkJ37MTZR1Yep6rFPnDjEol2N98R9Lo/OGvu2SMd5O6zzpbW6jhr6e6 gs1nvbeWF9FotGztoyXUR3XZ3HHWq56h85mokLqeii/pJpJVzai9+9oGFr0d6vL3dbI8 ildg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j8aqki5CcPtcLzfCY7Wo7lQT4J4ibEQGFMyeTxDiGAQ=; b=RgPe3BWg2augWcl0r4hqKmJdtXnnI6CtoB+KkSPp4KYfVHjo8GfIejjplM/Tyw+oj4 vSKt2seW1ken1+7YFgQIv99B8X2iADsMxBPBscTrUc9gkXrnPj1wTnTn6x4EjuPsj9gq zr/5PNwmvmJUjhGEUbTXrEUD/6/KRRo5wjSTGOFvcgW7XE8pQu7nHEd40RHXq4NXptri lQ2iA4jVL/hMkVLX98EycoreQ/d5xcLm+O61W4OK0mSGZde7E+jxm11bUBBXrNcqmv9K 8egdbpqlRBMYJU40QriUqFuoQhkPAwkzeONB800ADKcw9UruBMw5w7M0cuUm87TndgZT H1TQ== X-Gm-Message-State: AO0yUKUlDfXh8RoYsDFV1hE9EuNqkzmxmGgGVGY0lwmv10cUD6D/CVon vpJlikC75T9UvOP79zCOEH1axA== X-Google-Smtp-Source: AK7set8mh4lwRHVWgzw9plGkhTC0LxGuzA2btm4FE97PRWONLb5ri8GZ01gKo2/yhwB4ocF497kPxw== X-Received: by 2002:adf:f409:0:b0:2bf:bb71:dc55 with SMTP id g9-20020adff409000000b002bfbb71dc55mr16253917wro.52.1675024549902; Sun, 29 Jan 2023 12:35:49 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id f28-20020a5d58fc000000b002be5401ef5fsm10204173wrd.39.2023.01.29.12.35.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Jan 2023 12:35:49 -0800 (PST) Message-ID: <47ee24cd-4239-772b-6dc6-d0741e813f15@linaro.org> Date: Sun, 29 Jan 2023 21:35:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v7 1/2] power: supply: add Qualcomm PMI8998 SMB2 Charger driver To: Sebastian Reichel , Caleb Connolly Cc: Bjorn Andersson , Andy Gross , Rob Herring , Krzysztof Kozlowski , Konrad Dybcio , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org References: <20230127230506.3140297-1-caleb.connolly@linaro.org> <20230129202043.w6mylxeccz2fyxl2@mercury.elektranox.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230129202043.w6mylxeccz2fyxl2@mercury.elektranox.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/01/2023 21:20, Sebastian Reichel wrote: > Hi, > > I tried applying this, but it generates a compiler warning: > > On Fri, Jan 27, 2023 at 11:05:05PM +0000, Caleb Connolly wrote: >> [...] >> +static int smb2_probe(struct platform_device *pdev) >> +{ >> [...] >> + desc->name = devm_kasprintf(chip->dev, GFP_KERNEL, "%s-charger", >> + device_get_match_data(chip->dev)); > > drivers/power/supply/qcom_pmi8998_charger.c: In function ‘smb2_probe’: > drivers/power/supply/qcom_pmi8998_charger.c:979:62: warning: format ‘%s’ expects argument of type ‘char *’, but argument 4 has type ‘const void *’ [-Wformat=] > 979 | desc->name = devm_kasprintf(chip->dev, GFP_KERNEL, "%s-charger", > | ~^ > | | > | char * > | %p > 980 | device_get_match_data(chip->dev)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > | | > | const void * This was also reported now by kernel test robot. I wonder why there were no earlier reports... Best regards, Krzysztof