From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4AEC77B76 for ; Tue, 18 Apr 2023 12:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbjDRMZy (ORCPT ); Tue, 18 Apr 2023 08:25:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231429AbjDRMZu (ORCPT ); Tue, 18 Apr 2023 08:25:50 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B78928684 for ; Tue, 18 Apr 2023 05:25:15 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id q23so63201495ejz.3 for ; Tue, 18 Apr 2023 05:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681820713; x=1684412713; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ev5WXTYPPIhAR/I8OdIpkj/pJQ+EM34lzeYbEC9ASSY=; b=dt8agR7ooelnrNDzOe7AF25AFlJM3MwAKrXaOdy4Ey9KJNUCXogUfbKpjMSPn1pcuB 5Uv9nZRzQhygdFKEXC+jXG3NFBKjc2yT2CykBzR29oCJqOgy5TAnvSkbn1gZnp++AccP RI+5h1MwMjofbgIAdFtw38DAZ3rbO/ybPgyPEVsxAkMaATLt99maVNUTfaztdMnbM0EG MVJIdFT28y1VdNXKVrokaGOwzGTHFVpa713Mw6xLcH91X6YP6gs/8kOotNPZsz7JNCDC aupQp44QwVMxGwT/Sru0q4r6T+3UO8eC8I0RfM3bYb4UhcMH/04LPUo4r0JkjLPOT5PN NRoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681820713; x=1684412713; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ev5WXTYPPIhAR/I8OdIpkj/pJQ+EM34lzeYbEC9ASSY=; b=XUTiysY9fJ+DHSUrK77SsZg26Nlqkyq54EjxahzzgdcpfIBd3nmpXr19DWWnCladlH P4fsoYiYF8SK0xorc1QZQVMaLSHpIw8FVChRnHIUh0fKRQx9bKl+expgiE3oPCjHI+12 WquSSWv1+xT9AMpjcOWgI5dxaSGcHfWGGDoFA1PdXV1uVWJ1h8hjpnJuaTT5Oil38WXX RzLk0U9ASl4GCkRP9hRx7DxAgVl76XdV2x//m5oGzceDZI9XqUDvF6FsbcdvlH9p8xuX Y06RDlTa2IP3YDLqXJEL6zyndzaWYYTAk+kAnqMwvoTFjwftES5YgsjXpxMJviA/AZ7G KFjQ== X-Gm-Message-State: AAQBX9d9sWQ2N9IwFPDmsI/ovYOX3NkRu+AAbcxP6W+/ZusMOsnzRdc0 ztd9x0L8+2QwkPvHq+2Z6TVkoQ== X-Google-Smtp-Source: AKy350Z4tmX0U06wZCE6q5FdRMkDP7l+18lb+7cM4mckgyRf2TzhX9qVRGvgKAwF8u1OYfdAGS6qVg== X-Received: by 2002:a17:906:ae56:b0:932:1af9:7386 with SMTP id lf22-20020a170906ae5600b009321af97386mr10454741ejb.27.1681820713510; Tue, 18 Apr 2023 05:25:13 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:a276:7d35:5226:1c77? ([2a02:810d:15c0:828:a276:7d35:5226:1c77]) by smtp.gmail.com with ESMTPSA id oz8-20020a1709077d8800b009532427b35asm577349ejc.7.2023.04.18.05.25.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 05:25:13 -0700 (PDT) Message-ID: <47f27da1-8ed1-327e-74d7-ad4e3f12e3d6@linaro.org> Date: Tue, 18 Apr 2023 14:25:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 7/7] ASoC: dt-bindings: mediatek,mt8188-afe: add audio properties Content-Language: en-US To: =?UTF-8?B?VHJldm9yIFd1ICjlkLPmlofoia8p?= , "robh+dt@kernel.org" , "broonie@kernel.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "perex@perex.cz" , "angelogioacchino.delregno@collabora.com" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" References: <20230413104713.7174-1-trevor.wu@mediatek.com> <20230413104713.7174-8-trevor.wu@mediatek.com> <310e8979-de96-dda8-6c95-0e6033d8b403@linaro.org> <382bc15e-f4e3-3a9f-9dbc-4d46ac1d76d6@collabora.com> <3fe703c1279bf4d25a890b63c23a4bc97abd4198.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <3fe703c1279bf4d25a890b63c23a4bc97abd4198.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/04/2023 12:23, Trevor Wu (吳文良) wrote: >> Actually, doing that is borderline-ok... there's no devicetree for >> MT8188 >> upstream, so that's not breaking anything at all. >> In any case, I agree that you should generally avoid doing that but I >> think >> that in this specific case it's fine; I'm not a devicetree maintainer >> though. >> >> P.S.: Trevor, next time please make reviewers aware of the fact that >> no 8188 >> devicetree is present upstream! >> > Got it. Thanks. > > > Hi krzysztof, > > Because there is no upstream mt8188 DTS, should I move the new clock to > the end of clock list? What is the reason to add them in the middle? So far there was no argument, so always add at the end. If you have an argument, let's discuss it. > > If I move "apll1_d4" to the end of the list at binding file, when I > upstream the devicetree node existing clocks and clock-names properties > , should I follow the sequence defined in dt-bindings If you do not follow the sequence of bindings, you upstream incorrect DTS which does not follow ABI and fails the tests. Therefore yes, use the same order as your bindings define. > or can I have a > new sequence based on the clock type or alphabet? Sorry, I don't know what is the order of clock type and alphabet. If you mean anything else than bindings, then no, because how is it supposed to work then? Best regards, Krzysztof