From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
patches@linaro.org, linaro-kernel@lists.linaro.org,
devicetree-owner@vger.kernel.org
Subject: Re: [PATCH 7/7] arm64: dts: qcom: sm8250: add watchdog device
Date: Thu, 04 Jun 2020 18:22:53 +0530 [thread overview]
Message-ID: <47f338033abbf1470963d0a9e77d4449@codeaurora.org> (raw)
In-Reply-To: <20200604122259.GG16719@Mani-XPS-13-9360>
On 2020-06-04 17:52, Manivannan Sadhasivam wrote:
> On Thu, Jun 04, 2020 at 05:21:46PM +0530, Sai Prakash Ranjan wrote:
>> On 2020-06-04 17:05, Manivannan Sadhasivam wrote:
>> > On Thu, Jun 04, 2020 at 04:37:01PM +0530, Sai Prakash Ranjan wrote:
>> > > On 2020-06-04 06:13, Dmitry Baryshkov wrote:
>> > > > Add on-SoC watchdog device node.
>> > > >
>> > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> > > > ---
>> > > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 ++++++
>> > > > 1 file changed, 6 insertions(+)
>> > > >
>> > > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> > > > b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> > > > index 972d8e04c8a2..f1641c6fe203 100644
>> > > > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> > > > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> > > > @@ -1662,6 +1662,12 @@ config {
>> > > > };
>> > > > };
>> > > >
>> > > > + watchdog@17c10000 {
>> > > > + compatible = "qcom,apss-wdt-sm8250", "qcom,kpss-wdt";
>> > >
>> > > Need to add this compatible to bindings.
>> > >
>> >
>> > I did look into this but the binding says,
>> > "compatible : shall contain only one of the following"
>> >
>> > So clearly the fallback is not going to work and there is no need to add
>> > a
>> > dedicated compatible in the driver. The binding is not in the YAML
>> > format to
>> > be validated but still... Other option is to convert the binding to YAML
>> > and
>> > make the compatibles listed as 'enum' and 'const' elements
>> > appropriately.
>> >
>>
>> I already converted the bindings to YAML and added the missing
>> compatibles
>> for
>> other SoCs[1] .
>
> Ah, okay. I didn't find it in linux-next. Anyway, for adding
> "qcom,apss-wdt-sm8250" compatible, we need to group the compatibles
> wisely
> using 'enum' and 'const'.
>
Yes.
>> I thought it was already merged since Rob has already
>> reviewed
>> them, but seems like it was missed. Bjorn, can you please take it?
>>
>
> Perhaps for v5.9...
>
Sure, no problem.
Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-06-04 12:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 0:43 [PATCH 1/7] arm64: dts: qcom: pm8009: Add base dts file Dmitry Baryshkov
2020-06-04 0:43 ` [PATCH 2/7] arm64: dts: qcom: sm8250: change spmi node label Dmitry Baryshkov
2020-06-04 6:01 ` Manivannan Sadhasivam
2020-06-04 0:43 ` [PATCH 3/7] arm64: dts: qcom: sm8250-mtp: include pmic files Dmitry Baryshkov
2020-06-04 0:43 ` [PATCH 4/7] arm64: dts: qcom: sm8x50: add empty thermal zone nodes Dmitry Baryshkov
2020-06-08 8:45 ` Amit Kucheria
2020-06-04 0:43 ` [PATCH 5/7] arm64: dts: qcom: pm8150x: add thermal alarms and thermal zones Dmitry Baryshkov
2020-06-04 10:47 ` Vinod Koul
2020-06-04 15:03 ` Dmitry Baryshkov
2020-06-05 4:39 ` Vinod Koul
2020-06-05 14:37 ` Dmitry Baryshkov
2020-06-08 8:44 ` Amit Kucheria
2020-06-04 0:43 ` [PATCH 6/7] arm64: dts: qcom: pm8150: enable rtc device Dmitry Baryshkov
2020-06-04 6:09 ` Manivannan Sadhasivam
2020-06-04 10:51 ` Vinod Koul
2020-06-04 0:43 ` [PATCH 7/7] arm64: dts: qcom: sm8250: add watchdog device Dmitry Baryshkov
2020-06-04 6:06 ` Manivannan Sadhasivam
2020-06-04 10:52 ` Vinod Koul
2020-06-04 11:07 ` Sai Prakash Ranjan
2020-06-04 11:35 ` Manivannan Sadhasivam
2020-06-04 11:51 ` Sai Prakash Ranjan
2020-06-04 12:22 ` Manivannan Sadhasivam
2020-06-04 12:52 ` Sai Prakash Ranjan [this message]
2020-06-04 6:08 ` [PATCH 1/7] arm64: dts: qcom: pm8009: Add base dts file Manivannan Sadhasivam
2020-06-04 9:10 ` Vinod Koul
2020-06-21 6:42 ` Bjorn Andersson
2020-06-21 18:56 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47f338033abbf1470963d0a9e77d4449@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree-owner@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=patches@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).