* [PATCH] arm: dts: arm: versatile-ab: Fix duplicate clock node name
@ 2024-07-30 21:00 Rob Herring (Arm)
2024-07-31 15:14 ` Guenter Roeck
2024-08-02 20:56 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-07-30 21:00 UTC (permalink / raw)
To: soc, Linus Walleij, Krzysztof Kozlowski, Conor Dooley,
Sudeep Holla, Arnd Bergmann
Cc: Guenter Roeck, linux-arm-kernel, devicetree, linux-kernel
Commit 04f08ef291d4 ("arm/arm64: dts: arm: Use generic clock and
regulator nodenames") renamed nodes and created 2 "clock-24000000" nodes
(at different paths). The kernel can't handle these duplicate names
even though they are at different paths. Fix this by renaming one of
the nodes to "clock-pclk". This name is aligned with other Arm boards
(those didn't have a known frequency to use in the node name).
Fixes: 04f08ef291d4 ("arm/arm64: dts: arm: Use generic clock and regulator nodenames")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Arnd, I imagine you can take this directly.
arch/arm/boot/dts/arm/versatile-ab.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/arm/versatile-ab.dts b/arch/arm/boot/dts/arm/versatile-ab.dts
index 6fe6b49f5d8e..635ab9268899 100644
--- a/arch/arm/boot/dts/arm/versatile-ab.dts
+++ b/arch/arm/boot/dts/arm/versatile-ab.dts
@@ -157,7 +157,7 @@ timclk: clock-1000000 {
clocks = <&xtal24mhz>;
};
- pclk: clock-24000000 {
+ pclk: clock-pclk {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
clock-div = <1>;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: dts: arm: versatile-ab: Fix duplicate clock node name
2024-07-30 21:00 [PATCH] arm: dts: arm: versatile-ab: Fix duplicate clock node name Rob Herring (Arm)
@ 2024-07-31 15:14 ` Guenter Roeck
2024-08-02 20:56 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2024-07-31 15:14 UTC (permalink / raw)
To: Rob Herring (Arm), soc, Linus Walleij, Krzysztof Kozlowski,
Conor Dooley, Sudeep Holla, Arnd Bergmann
Cc: linux-arm-kernel, devicetree, linux-kernel
On 7/30/24 14:00, Rob Herring (Arm) wrote:
> Commit 04f08ef291d4 ("arm/arm64: dts: arm: Use generic clock and
> regulator nodenames") renamed nodes and created 2 "clock-24000000" nodes
> (at different paths). The kernel can't handle these duplicate names
> even though they are at different paths. Fix this by renaming one of
> the nodes to "clock-pclk". This name is aligned with other Arm boards
> (those didn't have a known frequency to use in the node name).
>
> Fixes: 04f08ef291d4 ("arm/arm64: dts: arm: Use generic clock and regulator nodenames")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Arnd, I imagine you can take this directly.
>
> arch/arm/boot/dts/arm/versatile-ab.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/arm/versatile-ab.dts b/arch/arm/boot/dts/arm/versatile-ab.dts
> index 6fe6b49f5d8e..635ab9268899 100644
> --- a/arch/arm/boot/dts/arm/versatile-ab.dts
> +++ b/arch/arm/boot/dts/arm/versatile-ab.dts
> @@ -157,7 +157,7 @@ timclk: clock-1000000 {
> clocks = <&xtal24mhz>;
> };
>
> - pclk: clock-24000000 {
> + pclk: clock-pclk {
> #clock-cells = <0>;
> compatible = "fixed-factor-clock";
> clock-div = <1>;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: dts: arm: versatile-ab: Fix duplicate clock node name
2024-07-30 21:00 [PATCH] arm: dts: arm: versatile-ab: Fix duplicate clock node name Rob Herring (Arm)
2024-07-31 15:14 ` Guenter Roeck
@ 2024-08-02 20:56 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2024-08-02 20:56 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: soc, Krzysztof Kozlowski, Conor Dooley, Sudeep Holla,
Arnd Bergmann, Guenter Roeck, linux-arm-kernel, devicetree,
linux-kernel
On Tue, Jul 30, 2024 at 11:01 PM Rob Herring (Arm) <robh@kernel.org> wrote:
> Commit 04f08ef291d4 ("arm/arm64: dts: arm: Use generic clock and
> regulator nodenames") renamed nodes and created 2 "clock-24000000" nodes
> (at different paths). The kernel can't handle these duplicate names
> even though they are at different paths. Fix this by renaming one of
> the nodes to "clock-pclk". This name is aligned with other Arm boards
> (those didn't have a known frequency to use in the node name).
>
> Fixes: 04f08ef291d4 ("arm/arm64: dts: arm: Use generic clock and regulator nodenames")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Oh excellent, thanks.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-02 20:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-30 21:00 [PATCH] arm: dts: arm: versatile-ab: Fix duplicate clock node name Rob Herring (Arm)
2024-07-31 15:14 ` Guenter Roeck
2024-08-02 20:56 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).