From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 545451552E0 for ; Mon, 19 May 2025 20:15:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747685748; cv=none; b=poaaZzp5jGCOGSU7YjDbjliImc08W/eXsY+9P8Gn+sTTq4mJUFcJxCiUHxttepXRoCX/HCWgSq3TgG9o2GWGbU4XjU2KFaDx9KgcbeJmN3niJh4aWtJd+m0NsMWFmVv7+BoXXXTMVN5w5bbPGJL38p2sfBb0YlUM5JOvV0jRQBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747685748; c=relaxed/simple; bh=8dX8Wr9L4YGOHz+wjN+mZYVu8hwJ3J7H6NpKgGMox/M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OjQcSiKZyWDNyYduVs3qxfLSLGCUS0OS4c3V5oPfFj1g+8klA4H5Y7esggxZKVJ8NvPJW+uNbbRLrvNxF821eYVe1dgtWUlDuhysFITeHWdKuRiJhvNURlc0L3A8eZRrvIr08b3o26QWkeA3axFVVlZNbDUtzCThSy7dYLpOtQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=McoLpWvC; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="McoLpWvC" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-72c13802133so1845346a34.3 for ; Mon, 19 May 2025 13:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1747685745; x=1748290545; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IxPqQrqptdt6ZRunnP9xjg4VsQBTXE7UdgcvpQp1vnQ=; b=McoLpWvC/nmgl4hDj9EwLeckCAoo+leQLspXx4bh9ImZrQf47pwCUDWTdKRnnHNogn ZUtD3L5SEDztK5Jh0rTftRqhzdKLWrKPI981NZWUwZ7IYrWawo2a5NDcbPOyLKibIh/D e+N1agNQgVEev7hx8R3jzncgmXsRiCckNodgNn6h5d3+ia+gM+j5F4Q3aOLYKcGyDf2h cFnUYjzoWGTG2js1WeQmkm4oJsL+ZnDtAgVathjQb+/7ioGepDPnL/msmyxHZwiAZPPs H2S4zU8HBbLKpq3cPmdOvzOHybV1P2RGFzs84TAK0242Ew/v2JEq2w5FJA/h7TJ6WUO2 KJiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747685745; x=1748290545; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IxPqQrqptdt6ZRunnP9xjg4VsQBTXE7UdgcvpQp1vnQ=; b=cw+zOyo50LBmwN75lAm1Yzsz3A6hy16H/sltaUW8YEdAPiAQprriTRZwjhHaGQyDgH DrfP3eY+R+d7cC0Fjj8SAQon3UF/W1wrnJyrxXTohQUCZ5v9/so2ugQqRO25CQ/Lsclu FYPipXcgbXc+niMDu0yan2fKDdszSEyAx6bvmaB7ufk7ybVL+PddXhvgjya/Kp/1x/e1 2dTSc6p9Y+gHUovPDGbeQp7lPIwLhtRYetj4CHFtez/H2naOcxDzGk1jwwgYYXyXaVEv X18V1NsVYTaEFVUTgJ005jUVEjq/rTYeFo1lQM2XoLfjvIlz5yjaiqfNq5MpH7fkqoiv 96zw== X-Forwarded-Encrypted: i=1; AJvYcCU0bWdxCdL9MQkO+wrjfvNrHZCL66+z8aAZk2r7cDjkRB94Pg7fYKg3I/ZH5sPOlUyPpoPSC7JSaOmy@vger.kernel.org X-Gm-Message-State: AOJu0YwjdGSSmTGNdlsCn9DoHdjWRyjkr3RiKCWAHsOZEgjVs9XqFMVk pIfT8XJ89KCOMOgnOQD7NPGh4EIeZ/gd1GewUTXBnKWgmvFFRhKXMX37nvNnTcxu+DBtSBCNqPO QD5NZ X-Gm-Gg: ASbGncsBOXuKL7WpCgg5WI9DySpqLGQX1a66V54ev1oIssxChJgteg4R6zWxspJa2+R GYSlKUMxu7dhFATKkcvGkaXDyDXX+Oy/SJTYqajJvkhOniioBl9kYjDTUeSvi7RqZqDKzruUYAj 02Tu/JV40bS289/fnUI9WeRFz7OpoMF786T5P6XMHjUUw2JMa/jcBiMAjLzKZYlUUaRFCaacffT KKjn1VD/1pVI8it1EQ8PHhqmCGwzH9AizF0YynohJcbCTk9EiIgLxdfygIsdCnSGYH1EmAZeEJ6 Ta5+KplRvS9nhk4KBrrD+tPYDdxhriXvFBP0K2S3uBKUS7k21CBAfPcbzpZyQNN9S/w5etYdzbr 1Qz+ROyC9IK8y9w9LVR7b10qPMceV X-Google-Smtp-Source: AGHT+IHnM+ogubTeRYfZUDZjML14fl+Syr5GdQv0cHx7rQtXJUm1hDhfIBt4qdixN9KogS4f8h/scQ== X-Received: by 2002:a05:6830:611c:b0:72b:8297:e988 with SMTP id 46e09a7af769-734f998dc0fmr8973347a34.25.1747685745325; Mon, 19 May 2025 13:15:45 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:4118:1770:ecaf:ee73? ([2600:8803:e7e4:1d00:4118:1770:ecaf:ee73]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-734f6b5f697sm1541527a34.57.2025.05.19.13.15.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 May 2025 13:15:44 -0700 (PDT) Message-ID: <4843ec52-57e2-418a-b640-8e05ba60959e@baylibre.com> Date: Mon, 19 May 2025 15:15:43 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes To: 1aff0f813bb3fee55c5483be860b6885abdb81e5.1747175187.git.Jonathan.Santos@analog.com, Jonathan Santos Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com, Michael.Hennerich@analog.com, marcelo.schmitt@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, marcelo.schmitt1@gmail.com, linus.walleij@linaro.org, brgl@bgdev.pl, lgirdwood@gmail.com, broonie@kernel.org, Pop Paul References: <1aff0f813bb3fee55c5483be860b6885abdb81e5.1747175187.git.Jonathan.Santos@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/19/25 12:13 PM, Jonathan Santos wrote: > On 05/15, Jonathan Santos wrote: ... >> + >> +/* Decimation Rate range for each filter type */ >> +static const int ad7768_dec_rate_range[][3] = { >> + [AD7768_FILTER_SINC5] = { 8, 8, 1024 }, >> + [AD7768_FILTER_SINC3] = { 32, 32, 163840 }, >> + [AD7768_FILTER_WIDEBAND] = { 32, 32, 1024 }, >> + [AD7768_FILTER_SINC3_REJ60] = { 32, 32, 163840 }, >> +}; >> + > > Since we're still discussing some points — is the `step` in > `[min step max]` for the IIO range additive or multiplicative? It is not > clear on documentation, maybe on purpose or I have missed something. > > Here, decimation/OSR doubles from 8 or 32 for SINC5/WIDEBAND, and is a > multiple of 32 for SINC3. So I'm still unsure how to represent this to be > clear to the user. Sounds to me like sinc5/wideband should be lists instead of ranges. It is only 6 values.