From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jernej =?utf-8?B?xaBrcmFiZWM=?= Subject: Re: [PATCH 01/13] dt-bindings: update the binding for Allwinner H3 DE2 support Date: Wed, 02 Aug 2017 21:06:26 +0200 Message-ID: <48442573.082BymFnMM@jernej-laptop> References: <20170801131304.7741-1-icenowy@aosc.io> <79034825.lnfmIyYlWl@jernej-laptop> Reply-To: jernej.skrabec-gGgVlfcn5nU@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, icenowy-h8G6r0blFSE@public.gmane.org Cc: Maxime Ripard , Rob Herring , Chen-Yu Tsai , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, Dne sreda, 02. avgust 2017 ob 07:02:39 CEST je icenowy-h8G6r0blFSE@public.gmane.org napisal(a): > =E5=9C=A8 2017-08-02 12:53=EF=BC=8CJernej =C5=A0krabec =E5=86=99=E9=81=93= =EF=BC=9A >=20 > > Hi Icenowy, > >=20 > > Dne torek, 01. avgust 2017 ob 15:12:52 CEST je Icenowy Zheng > >=20 > > napisal(a): > >> Allwinner H3 features a "Display Engine 2.0". > >>=20 > >> Add device tree bindings for the following parts: > >> - H3 TCONs > >> - H3 Mixers > >> - H3 Display engine > >>=20 > >> Signed-off-by: Icenowy Zheng > >> --- > >>=20 > >> .../bindings/display/sunxi/sun4i-drm.txt | 25 > >>=20 > >> ++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 > >> deletions(-) > >>=20 > >> diff --git > >> a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > >> b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt index > >> 2ee6ff0ef98e..92512953943e 100644 > >> --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > >> +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > >>=20 > >> @@ -87,18 +87,17 @@ Required properties: > >> * allwinner,sun6i-a31-tcon > >> * allwinner,sun6i-a31s-tcon > >> * allwinner,sun8i-a33-tcon > >>=20 > >> + * allwinner,sun8i-h3-tcon > >>=20 > >> * allwinner,sun8i-v3s-tcon > >> =20 > >> - reg: base address and size of memory-mapped region > >> - interrupts: interrupt associated to this IP > >> =20 > >> - clocks: phandles to the clocks feeding the TCON. Three are needed: > >> - 'ahb': the interface clocks > >>=20 > >> - - 'tcon-ch0': The clock driving the TCON channel 0 > >>=20 > >> - resets: phandles to the reset controllers driving the encoder > >> =20 > >> - "lcd": the reset line for the TCON channel 0 > >> =20 > >> - clock-names: the clock names mentioned above > >> - reset-names: the reset names mentioned above > >>=20 > >> - - clock-output-names: Name of the pixel clock created > >>=20 > >> - ports: A ports node with endpoint definitions as defined in > >> =20 > >> Documentation/devicetree/bindings/media/video-interfaces.txt. The > >>=20 > >> @@ -112,7 +111,23 @@ Required properties: > >> channel the endpoint is associated to. If that property is not > >> present, the endpoint number will be used as the channel number. > >>=20 > >> -On SoCs other than the A33 and V3s, there is one more clock required: > >> +For the following compatibles: > >> + * allwinner,sun5i-a13-tcon > >> + * allwinner,sun6i-a31-tcon > >> + * allwinner,sun6i-a31s-tcon > >> + * allwinner,sun8i-a33-tcon > >> + * allwinner,sun8i-v3s-tcon > >> +there is one more clock and one more property required: > >> + - clocks: > >> + - 'tcon-ch0': The clock driving the TCON channel 0 > >> + - clock-output-names: Name of the pixel clock created > >> + > >> +For the following compatibles: > >> + * allwinner,sun5i-a13-tcon > >> + * allwinner,sun6i-a31-tcon > >> + * allwinner,sun6i-a31s-tcon > >> + * allwinner,sun8i-h3-tcon > >>=20 > >> +there is one more clock required: > >> - 'tcon-ch1': The clock driving the TCON channel 1 > >> =20 > >> DRC > >>=20 > >> @@ -207,6 +222,8 @@ supported. > >>=20 > >> Required properties: > >> - compatible: value must be one of: > >> * allwinner,sun8i-v3s-de2-mixer > >>=20 > >> + * allwinner,sun8i-h3-de2-mixer0 > >> + * allwinner,sun8i-h3-de2-mixer1 > >=20 > > About that, I concur with Maxime here, plane number properties would be > > better. If we don't do this now, we will never have it. >=20 > But I still prefer different compatibles, as the capabilities are > already > proven to be different between mixer0 and mixer1, and furtherly we > cannot > promise Allwinner won't add more functions only available at mixer0. >=20 > Then we will be trapped into a situation that we describe more and more > functions via properties, but they should be encoded into the > compatible. It is either multiple compatibles or multiple properties. I prefer the late= r,=20 but it is up to maintainers to decide. Anyway, I think DE2 will not evolve much since DE3 is almost ready (H6). At= =20 least basics seems to be similar according to a BSP code drop. Regards, Jernej >=20 > > Reference: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2017-June/512902.= htm > > l > >=20 > > Regards, > > Jernej >=20 > -- > You received this message because you are subscribed to the Google Groups > "linux-sunxi" group. To unsubscribe from this group and stop receiving > emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org= . > For more options, visit https://groups.google.com/d/optout. --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.