From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 1/5] phy: Add a driver for simple phy Date: Sat, 16 Apr 2016 21:50:26 +0200 Message-ID: <4848615.OezLJod6Cv@wuerfel> References: <1447708924-15076-1-git-send-email-albeu@free.fr> <1447708924-15076-2-git-send-email-albeu@free.fr> <570F303A.6030605@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <570F303A.6030605-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kishon Vijay Abraham I Cc: Alban Bedel , linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ralf Baechle , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thursday 14 April 2016 11:22:58 Kishon Vijay Abraham I wrote: > > IMO simple-phy driver should be an independent driver and shouldn't export > symbols. The dt binding for the simple phy device should be something like > below where all the properties of the simple phy device should be in the > binding documentation. > usbphy { > compatible = "simple-phy"; > phy-supply = <&supply>; > clocks = <&clock>; > reset = <&reset>; > }; > > Anything that needs more than this shouldn't be a simple phy. I think there are two aspects here: a) I agree that a driver that matches "simple-phy" should only call the generic functions and not use any other properties. b) Independent of that, I think that it makes a lot of sense to export those functions from the generic PHY subsystems so they can be called from drivers that are a little less generic, or that already have an established binding but need no other code. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html