public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Artur Rojek <artur@conclusive.pl>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, Jakub Klama <jakub@conclusive.pl>,
	Wojciech Kloska	 <wojciech@conclusive.pl>,
	Ulf Axelsson <ulf.axelsson@nordicsemi.no>
Subject: Re: [RFC PATCH v2 0/2] wifi: Nordic nRF70 series
Date: Fri, 25 Apr 2025 20:11:22 +0200	[thread overview]
Message-ID: <4854f6a248fdc501d4157339fdb21f9a3ca3097d.camel@sipsolutions.net> (raw)
In-Reply-To: <20250422175918.585022-1-artur@conclusive.pl>

On Tue, 2025-04-22 at 19:59 +0200, Artur Rojek wrote:
> 1) Nordic gave us permission to upstream the firmware blob [1] required
>    to use this driver. As that needs to go through separate
>    linux-firmware repository and is subject to different licensing,
>    should I try to upstream it in parallel with this series, or does it
>    need to wait until the kernel driver gets in?

I have no idea. Chicken and egg, I guess.

> 2) In AP mode, for each connected peer I maintain a pending queue for TX
>    skbs that can't be transmitted while the peer is in power save mode.
>    I then use a wiphy_work (nrf70_pending_worker) to move the collected
>    skbs into a single hw queue once the peer is able to receive again.
>    This means there can be multiple workers putting skbs onto the hw
>    queue at any given time. As this scheme relies on the wiphy_work
>    workqueue, can I assume that multiple workers will be able to run in
>    parallel, even on a system with a single CPU? If not, what would be
>    a better solution to the above problem?

wiphy_work() is fully serialized regardless of the number of CPUs, it's
guaranteed that the wiphy mutex is held for the work execution, after
all.

johannes

  parent reply	other threads:[~2025-04-25 18:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 17:59 [RFC PATCH v2 0/2] wifi: Nordic nRF70 series Artur Rojek
2025-04-22 17:59 ` [RFC PATCH v2 1/2] dt-bindings: wifi: Add support for Nordic nRF70 Artur Rojek
2025-04-25 10:38   ` Krzysztof Kozlowski
2025-04-22 17:59 ` [RFC PATCH v2 2/2] wifi: Add Nordic nRF70 series Wi-Fi driver Artur Rojek
2025-04-24 15:07   ` Johannes Berg
2025-04-25 16:49     ` Artur Rojek
2025-04-25 18:09       ` Johannes Berg
2025-05-01 10:34         ` Artur Rojek
2025-04-25 19:31   ` Christophe JAILLET
2025-05-01 10:41     ` Artur Rojek
2025-05-01 17:44       ` Christophe JAILLET
2025-04-25 18:11 ` Johannes Berg [this message]
2025-04-28  8:45   ` [RFC PATCH v2 0/2] wifi: Nordic nRF70 series Arend van Spriel
2025-04-28 17:10     ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4854f6a248fdc501d4157339fdb21f9a3ca3097d.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=artur@conclusive.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jakub@conclusive.pl \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=ulf.axelsson@nordicsemi.no \
    --cc=wojciech@conclusive.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox