From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D0CEB64DD for ; Mon, 24 Jul 2023 19:09:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbjGXTJk (ORCPT ); Mon, 24 Jul 2023 15:09:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbjGXTJj (ORCPT ); Mon, 24 Jul 2023 15:09:39 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10E8A10EF; Mon, 24 Jul 2023 12:09:36 -0700 (PDT) Received: from [193.138.155.172] (helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qO0vg-00007Z-4h; Mon, 24 Jul 2023 21:09:12 +0200 From: Heiko Stuebner To: Alban Bedel , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Doug Berger , Broadcom internal kernel review list , Eugeniy Paltsev , Orson Zhai , Baolin Wang , Chunyan Zhang , Daniel Palmer , Romain Perier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han , Rob Herring Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] gpio: Explicitly include correct DT includes Date: Mon, 24 Jul 2023 21:09:09 +0200 Message-ID: <4869844.Mh6RI2rZIc@phil> In-Reply-To: <20230714174525.4055475-1-robh@kernel.org> References: <20230714174525.4055475-1-robh@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Freitag, 14. Juli 2023, 19:44:58 CEST schrieb Rob Herring: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > drivers/gpio/gpio-rockchip.c | 2 +- for rockchip: Acked-by: Heiko Stuebner