From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Frank Wunderlich <linux@fw-web.de>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Wenbin Mei <wenbin.mei@mediatek.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, daniel@makrotopia.org,
john@phrozen.org, eladwf@gmail.com, ansuelsmth@gmail.com
Subject: Re: Aw: Re: [PATCH v2 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC
Date: Mon, 7 Oct 2024 09:04:15 +0200 [thread overview]
Message-ID: <486a85cb-8e09-493b-93f8-6610855b5f7e@kernel.org> (raw)
In-Reply-To: <trinity-57600902-afb6-42f3-8cf5-54a07710f979-1728284364104@3c-app-gmx-bap03>
On 07/10/2024 08:59, Frank Wunderlich wrote:
>> Gesendet: Montag, 07. Oktober 2024 um 07:55 Uhr
>> Von: "Krzysztof Kozlowski" <krzk@kernel.org>
>> An: "Frank Wunderlich" <linux@fw-web.de>
>> Betreff: Re: [PATCH v2 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC
>>
>> On Sun, Oct 06, 2024 at 05:34:45PM +0200, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> Add binding definitions for mmc on MT7988 SoC.
>>>
>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>>> ---
>>> v2:
>>> - fixed minItems to 4
>>> ---
>>> .../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++
>>> 1 file changed, 24 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> index c532ec92d2d9..7380f72ea189 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> @@ -21,6 +21,7 @@ properties:
>>> - mediatek,mt7620-mmc
>>> - mediatek,mt7622-mmc
>>> - mediatek,mt7986-mmc
>>> + - mediatek,mt7988-mmc
>>> - mediatek,mt8135-mmc
>>> - mediatek,mt8173-mmc
>>> - mediatek,mt8183-mmc
>>> @@ -263,6 +264,29 @@ allOf:
>>> - const: bus_clk
>>> - const: sys_cg
>>>
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - mediatek,mt7988-mmc
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 4
>>
>> Drop
Drop this line.
>>
>>> + items:
>>> + - description: source clock
>>> + - description: HCLK which used for host
>>> + - description: Advanced eXtensible Interface
>>> + - description: Advanced High-performance Bus clock
>>> + clock-names:
>>> + minItems: 3
>>
>> This is still wrong... anyway, drop.
>
> arg, sorry again...i should triple-check all before resending.
Drop this line.
>
> but dropping means the global 2 is used (making axi+ahb optional), or am i wrong? afaik "minItems: 4" is right here
How minItems:4 is right here?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-07 7:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 15:34 [PATCH v2 0/2] Add mmc support for mt7988 Frank Wunderlich
2024-10-06 15:34 ` [PATCH v2 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC Frank Wunderlich
2024-10-07 5:55 ` Krzysztof Kozlowski
2024-10-07 6:59 ` Aw: " Frank Wunderlich
2024-10-07 7:04 ` Krzysztof Kozlowski [this message]
2024-10-07 7:56 ` Aw: " Frank Wunderlich
2024-10-07 11:13 ` Krzysztof Kozlowski
2024-10-07 8:00 ` AngeloGioacchino Del Regno
2024-10-07 8:33 ` Aw: " Frank Wunderlich
2024-10-07 10:12 ` AngeloGioacchino Del Regno
2024-10-07 11:36 ` Daniel Golle
2024-10-06 15:34 ` [PATCH v2 2/2] mmc: mtk-sd: add support for mt7988 Frank Wunderlich
2024-10-07 7:58 ` AngeloGioacchino Del Regno
2024-10-07 8:37 ` Aw: " Frank Wunderlich
2024-10-07 10:14 ` AngeloGioacchino Del Regno
2024-10-07 11:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486a85cb-8e09-493b-93f8-6610855b5f7e@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=chaotian.jing@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=eladwf@gmail.com \
--cc=frank-w@public-files.de \
--cc=john@phrozen.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).