From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sricharan Ramabadhran <quic_srichara@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, srinivas.kandagatla@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org,
daniel.lezcano@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 4/7] thermal/drivers/qcom: Add IPQ5018 compatible
Date: Mon, 28 Aug 2023 21:33:49 +0200 [thread overview]
Message-ID: <4882b193-9135-f5f1-74b7-7321ced261ef@linaro.org> (raw)
In-Reply-To: <1693250307-8910-5-git-send-email-quic_srichara@quicinc.com>
On 28/08/2023 21:18, Sricharan Ramabadhran wrote:
> IPQ5018 has tsens V1.0 IP with 4 sensors and 1 interrupt.
>
> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> ---
> drivers/thermal/qcom/tsens.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index f39495b61952..a24eb88b3444 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -1101,6 +1101,9 @@ static SIMPLE_DEV_PM_OPS(tsens_pm_ops, tsens_suspend, tsens_resume);
>
> static const struct of_device_id tsens_table[] = {
> {
> + .compatible = "qcom,ipq5018-tsens",
> + .data = &data_ipq5018,
> + }, {
This patch does not make sense on its own. It must be squashed. You
already brought the IPQ5018 in previous patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-28 19:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 19:18 [PATCH 0/7] Add support for IPQ5018 tsens Sricharan Ramabadhran
2023-08-28 19:18 ` [PATCH 1/7] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible Sricharan Ramabadhran
2023-08-28 19:21 ` Krzysztof Kozlowski
2023-08-29 5:59 ` Sricharan Ramabadhran
2023-08-28 19:18 ` [PATCH 2/7] thermal/drivers/qcom: Add new feat for soc without rpm Sricharan Ramabadhran
2023-08-28 21:17 ` Dmitry Baryshkov
2023-08-29 6:01 ` Sricharan Ramabadhran
2023-08-28 19:18 ` [PATCH 3/7] thermal/drivers/qcom/tsens: Add support for IPQ5018 tsens Sricharan Ramabadhran
2023-08-28 19:33 ` Krzysztof Kozlowski
2023-08-29 6:02 ` Sricharan Ramabadhran
2023-08-28 21:15 ` Dmitry Baryshkov
2023-08-30 2:20 ` Sricharan Ramabadhran
2023-08-28 19:18 ` [PATCH 4/7] thermal/drivers/qcom: Add IPQ5018 compatible Sricharan Ramabadhran
2023-08-28 19:33 ` Krzysztof Kozlowski [this message]
2023-08-29 6:03 ` Sricharan Ramabadhran
2023-08-28 19:18 ` [PATCH 5/7] dt-bindings: nvmem: Add compatible for IPQ5018 Sricharan Ramabadhran
2023-08-28 19:23 ` Krzysztof Kozlowski
2023-08-28 19:18 ` [PATCH 6/7] arm64: dts: qcom: ipq5018: Add tsens node Sricharan Ramabadhran
2023-08-28 19:25 ` Krzysztof Kozlowski
2023-08-29 6:04 ` Sricharan Ramabadhran
2023-08-28 21:19 ` Dmitry Baryshkov
2023-08-28 19:18 ` [PATCH 7/7] arm64: dts: qcom: ipq5018: Add thermal zones Sricharan Ramabadhran
2023-08-28 19:34 ` Krzysztof Kozlowski
2023-08-29 6:05 ` Sricharan Ramabadhran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4882b193-9135-f5f1-74b7-7321ced261ef@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_srichara@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).