devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Meng Li <Meng.Li@windriver.com>,
	gregkh@linuxfoundation.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	dinguyen@kernel.org, hminas@synopsys.com,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg"
Date: Wed, 19 Jul 2023 08:39:18 +0200	[thread overview]
Message-ID: <488835c0-e08e-c0cc-abac-192f658b093f@linaro.org> (raw)
In-Reply-To: <20230719025509.3007986-4-Meng.Li@windriver.com>

On 19/07/2023 04:55, Meng Li wrote:
> Add the compatible "intel,socfpga-stratix10-hsotg" to the DWC2
> implementation, because the Stratix DWC2 implementation does
> not support clock gating. This compatible is used with generic
> snps,dwc2.
> 
> Signed-off-by: Meng Li <Meng.Li@windriver.com>

Missing changelog, missing versioning. This is v3 or v4.

> ---
>  Documentation/devicetree/bindings/usb/dwc2.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index dc4988c0009c..f90094320914 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -51,6 +51,7 @@ properties:
>                - amlogic,meson-g12a-usb
>                - amlogic,meson-a1-usb
>                - intel,socfpga-agilex-hsotg
> +              - intel,socfpga-stratix10-hsotg

So you just sent the same patch as before. I pointed you to the proper
solution with compatibility.



Best regards,
Krzysztof


  reply	other threads:[~2023-07-19  6:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19  2:55 [PATCH 0/3] Patches used to add platform specific data for Intel Stratix10 platform Meng Li
2023-07-19  2:55 ` [PATCH 1/3] usb: dwc2: Add " Meng Li
2023-07-19  6:39   ` Krzysztof Kozlowski
2023-07-19  9:10     ` Li, Meng
2023-07-19  9:20       ` Krzysztof Kozlowski
2023-07-19  2:55 ` [PATCH 2/3] arm64: dts: agilex: use the compatible "intel,socfpga-agilex-hsotg" Meng Li
2023-07-19  2:55 ` [PATCH 3/3] dt-bindings: usb: dwc2: add compatible "intel,socfpga-stratix10-hsotg" Meng Li
2023-07-19  6:39   ` Krzysztof Kozlowski [this message]
2023-07-19  8:45     ` Li, Meng
2023-07-19  8:59       ` Krzysztof Kozlowski
2023-07-19  9:49         ` Li, Meng
2023-07-19  9:52           ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488835c0-e08e-c0cc-abac-192f658b093f@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Meng.Li@windriver.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hminas@synopsys.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).