From: "Yong Wu (吴勇)" <Yong.Wu@mediatek.com>
To: "amergnat@baylibre.com" <amergnat@baylibre.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH RESEND 1/6] dt-bindings: memory-controllers: mediatek,smi-common: add mt8365
Date: Thu, 30 Mar 2023 01:53:57 +0000 [thread overview]
Message-ID: <488d226a8a66bc6f5b96063b2816b59dd065ad3f.camel@mediatek.com> (raw)
In-Reply-To: <20230207-iommu-support-v1-1-4a902f9aa412@baylibre.com>
On Wed, 2023-03-29 at 11:52 +0200, Alexandre Mergnat wrote:
>
> Add binding description for mediatek,mt8365-smi-common
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> .../devicetree/bindings/memory-controllers/mediatek,smi-
> common.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/memory-
> controllers/mediatek,smi-common.yaml
> b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-
> common.yaml
> index a8fda30cccbb..d599a190952f 100644
> --- a/Documentation/devicetree/bindings/memory-
> controllers/mediatek,smi-common.yaml
> +++ b/Documentation/devicetree/bindings/memory-
> controllers/mediatek,smi-common.yaml
> @@ -49,6 +49,10 @@ properties:
> - const: mediatek,mt7623-smi-common
> - const: mediatek,mt2701-smi-common
>
> + - items:
> + - const: mediatek,mt8365-smi-common
> + - const: mediatek,mt8186-smi-common
> +
mt8365 is not same with mt8186.
From the code, the bus_sel for mt8186 is:
.bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(4) | F_MMU1_LARB(7),
the bus_sel for mt8365 is:
.bus_sel = F_MMU1_LARB(2) | F_MMU1_LARB(4),
I guess we should add a independent "mediatek,mt8365-smi-common".
> reg:
> maxItems: 1
>
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-03-30 1:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 9:52 [PATCH RESEND 0/6] Add IOMMU support to MT8365 SoC Alexandre Mergnat
2023-03-29 9:52 ` [PATCH RESEND 1/6] dt-bindings: memory-controllers: mediatek,smi-common: add mt8365 Alexandre Mergnat
2023-03-29 10:41 ` Matthias Brugger
2023-03-30 1:53 ` Yong Wu (吴勇) [this message]
2023-03-29 9:52 ` [PATCH RESEND 2/6] dt-bindings: memory-controllers: mediatek,smi-larb: " Alexandre Mergnat
2023-03-29 10:41 ` Matthias Brugger
2023-03-29 9:52 ` [PATCH RESEND 3/6] arm64: dts: mediatek: add power domain support for mt8365 SoC Alexandre Mergnat
2023-03-29 13:36 ` AngeloGioacchino Del Regno
2023-03-29 9:52 ` [PATCH RESEND 4/6] arm64: dts: mediatek: add smi " Alexandre Mergnat
2023-03-29 13:36 ` AngeloGioacchino Del Regno
2023-03-29 9:52 ` [PATCH RESEND 5/6] arm64: dts: mediatek: add larb " Alexandre Mergnat
2023-03-29 13:37 ` AngeloGioacchino Del Regno
2023-03-29 9:52 ` [PATCH RESEND 6/6] arm64: dts: mediatek: add iommu " Alexandre Mergnat
2023-03-29 13:37 ` AngeloGioacchino Del Regno
2023-03-30 1:52 ` Yong Wu (吴勇)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488d226a8a66bc6f5b96063b2816b59dd065ad3f.camel@mediatek.com \
--to=yong.wu@mediatek.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).