From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>, devicetree@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org, jagan@edgeble.ai,
heiko@sntech.de, conor+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add saradc node to rk3588s-indiedroid-nova
Date: Tue, 12 Sep 2023 10:31:19 +0200 [thread overview]
Message-ID: <488e1f3b-e12b-c278-ed04-a2a5c807bc72@linaro.org> (raw)
In-Reply-To: <20230908164156.2846-4-macroalpha82@gmail.com>
On 08/09/2023 18:41, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add ADC support for the Indiedroid Nova, as well as the two ADC buttons
> found on the device. The buttons are documented as "boot" and
> "recovery". The boot button is used by the bootloader to boot into USB
> recovery mode. The recovery button use is currently unknown.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> .../dts/rockchip/rk3588s-indiedroid-nova.dts | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
> index 1e2336d3065b..4c2d662d9c97 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
> @@ -3,6 +3,7 @@
> /dts-v1/;
>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> #include <dt-bindings/pinctrl/rockchip.h>
> #include <dt-bindings/usb/pd.h>
> #include "rk3588s.dtsi"
> @@ -11,6 +12,34 @@ / {
> model = "Indiedroid Nova";
> compatible = "indiedroid,nova", "rockchip,rk3588s";
>
> + adc_keys0 {
No underscores in node names.
Suffixes usually are after -
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-12 8:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 16:41 [PATCH 0/3] Add Additional Functionality to Indiedroid Nova Chris Morgan
2023-09-08 16:41 ` [PATCH 1/3] arm64: dts: rockchip: add PCIe to rk3588s-indiedroid-nova Chris Morgan
2023-09-08 16:41 ` [PATCH 2/3] arm64: dts: rockchip: add USB2 to rk3588s-indiedroid Chris Morgan
2023-09-08 16:41 ` [PATCH 3/3] arm64: dts: rockchip: Add saradc node to rk3588s-indiedroid-nova Chris Morgan
2023-09-12 8:31 ` Krzysztof Kozlowski [this message]
2023-09-15 16:49 ` Chris Morgan
[not found] ` <ZQSK/+cOMhtu5Al0@wintermute.localhost.fail>
2023-09-15 17:05 ` Chris Morgan
2023-09-16 20:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488e1f3b-e12b-c278-ed04-a2a5c807bc72@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).