From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: soc@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: arm: uniphier: Add system controller bindings
Date: Tue, 8 Nov 2022 12:09:30 +0100 [thread overview]
Message-ID: <48988a50-3c3d-7a85-af28-66f7842e5893@linaro.org> (raw)
In-Reply-To: <20221107103410.3443-2-hayashi.kunihiko@socionext.com>
On 07/11/2022 11:34, Kunihiko Hayashi wrote:
> Add DT binding schema for system controller implemented in UniPhier SoCs.
> This describes that the nodes defined here are treated as "syscon".
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> .../socionext/socionext,uniphier-sysctrl.yaml | 92 +++++++++++++++++++
> 1 file changed, 92 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/socionext/socionext,uniphier-sysctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/socionext/socionext,uniphier-sysctrl.yaml b/Documentation/devicetree/bindings/arm/socionext/socionext,uniphier-sysctrl.yaml
> new file mode 100644
> index 000000000000..be7cf72c232e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/socionext/socionext,uniphier-sysctrl.yaml
arm is only for top-level stuff. System controllers go to soc.
> @@ -0,0 +1,92 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/socionext/socionext,uniphier-sysctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext UniPhier system controller
> +
> +maintainers:
> + - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +description: |+
> + This describes the devicetree bindings for system controller
> + implemented on Socionext UniPhier SoCs.
Drop "This describes the devicetree bindings for" and instead describe
the hardware.
> +
> +properties:
> + compatible:
> + oneOf:
You do not have more than one entry, so no need for oneOf.
> + - items:
> + - enum:
> + # sysctrl
> + - socionext,uniphier-ld4-sysctrl
> + - socionext,uniphier-pro4-sysctrl
> + - socionext,uniphier-pro5-sysctrl
> + - socionext,uniphier-pxs2-sysctrl
> + - socionext,uniphier-ld6b-sysctrl
> + - socionext,uniphier-sld8-sysctrl
> + - socionext,uniphier-ld11-sysctrl
> + - socionext,uniphier-ld20-sysctrl
> + - socionext,uniphier-pxs3-sysctrl
> + - socionext,uniphier-nx1-sysctrl
> + - socionext,uniphier-sysctrl
> + # soc-glue
> + - socionext,uniphier-ld4-soc-glue
> + - socionext,uniphier-pro4-soc-glue
> + - socionext,uniphier-pro5-soc-glue
> + - socionext,uniphier-pxs2-soc-glue
> + - socionext,uniphier-ld6b-soc-glue
> + - socionext,uniphier-sld8-soc-glue
> + - socionext,uniphier-ld11-soc-glue
> + - socionext,uniphier-ld20-soc-glue
> + - socionext,uniphier-pxs3-soc-glue
> + - socionext,uniphier-nx1-soc-glue
> + - socionext,uniphier-soc-glue
> + # perictrl
> + - socionext,uniphier-ld4-perictrl
> + - socionext,uniphier-pro4-perictrl
> + - socionext,uniphier-pro5-perictrl
> + - socionext,uniphier-pxs2-perictrl
> + - socionext,uniphier-ld6b-perictrl
> + - socionext,uniphier-sld8-perictrl
> + - socionext,uniphier-ld11-perictrl
> + - socionext,uniphier-ld20-perictrl
> + - socionext,uniphier-pxs3-perictrl
> + - socionext,uniphier-nx1-perictrl
> + - socionext,uniphier-perictrl
> + # sdctrl
> + - socionext,uniphier-ld4-sdctrl
> + - socionext,uniphier-pro4-sdctrl
> + - socionext,uniphier-pro5-sdctrl
> + - socionext,uniphier-pxs2-sdctrl
> + - socionext,uniphier-ld6b-sdctrl
> + - socionext,uniphier-sld8-sdctrl
> + - socionext,uniphier-ld11-sdctrl
> + - socionext,uniphier-ld20-sdctrl
> + - socionext,uniphier-pxs3-sdctrl
> + - socionext,uniphier-nx1-sdctrl
> + - socionext,uniphier-sdctrl
> + # mioctrl
> + - socionext,uniphier-ld4-mioctrl
> + - socionext,uniphier-pro4-mioctrl
> + - socionext,uniphier-sld8-mioctrl
> + - socionext,uniphier-ld11-mioctrl
> + - socionext,uniphier-mioctrl
> + # adamv
> + - socionext,uniphier-ld11-adamv
> + - socionext,uniphier-ld20-adamv
> + - socionext,uniphier-adamv
> + - const: simple-mfd
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties:
> + type: object
No, instead you should describe the children. This must me
additionalProperties: false
You also miss example.
Start from example-schema as your template or guidance.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-08 11:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 10:34 [PATCH v2 0/5] Add UniPhier boards support Kunihiko Hayashi
2022-11-07 10:34 ` [PATCH v2 1/5] dt-bindings: arm: uniphier: Add system controller bindings Kunihiko Hayashi
2022-11-08 11:09 ` Krzysztof Kozlowski [this message]
2022-11-08 14:30 ` Kunihiko Hayashi
2022-11-08 15:08 ` Krzysztof Kozlowski
2022-11-11 8:49 ` Kunihiko Hayashi
2022-11-07 10:34 ` [PATCH v2 2/5] dt-bindings: arm: uniphier: Add Pro5 boards Kunihiko Hayashi
2022-11-07 10:34 ` [PATCH v2 3/5] ARM: dts: uniphier: Add Pro5 board support Kunihiko Hayashi
2022-11-07 10:34 ` [PATCH v2 4/5] dt-bindings: arm: uniphier: Add NX1 boards Kunihiko Hayashi
2022-11-07 10:34 ` [PATCH v2 5/5] arm64: dts: uniphier: Add NX1 SoC and boards support Kunihiko Hayashi
2022-11-08 11:13 ` Krzysztof Kozlowski
2022-11-08 14:30 ` Kunihiko Hayashi
2022-11-08 15:11 ` Krzysztof Kozlowski
2022-11-11 8:48 ` Kunihiko Hayashi
2022-11-11 14:40 ` Krzysztof Kozlowski
2022-11-11 16:42 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48988a50-3c3d-7a85-af28-66f7842e5893@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).