From: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: John Rigby <jrigby-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree.
Date: Tue, 05 Aug 2008 16:20:52 -0500 [thread overview]
Message-ID: <4898C434.4040408@freescale.com> (raw)
In-Reply-To: <4898C34C.5000305-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
John Rigby wrote:
> I would like to use mpc83xx_add_bridge for 5121. This is why I
> moved it to fsl_pci.c. It currently uses get_immrbase and adds
> 0x8300 and 0x8304 to it to pass to setup_indirect_pci as the
> cfg_addr, and cfg_data addresses.
>
> I'm more than willing to change mpc83xx_add_bridge to not use
> get_immrbase. One simple solution is to pass the cfg_addr and
> cfg_data addresses in. If that seems ok then thats what I will do.
We should really be putting those addresses in the "reg" property of the
PCI node.
-Scott
next prev parent reply other threads:[~2008-08-05 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1217967220-30557-1-git-send-email-jrigby@freescale.com>
[not found] ` <1217967220-30557-2-git-send-email-jrigby@freescale.com>
[not found] ` <fa686aa40808051405j7268c216j8e5b526d6ad526c9@mail.gmail.com>
2008-08-05 21:05 ` [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree Grant Likely
2008-08-05 21:17 ` John Rigby
[not found] ` <4898C34C.5000305-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2008-08-05 21:20 ` Scott Wood [this message]
2008-08-05 21:38 ` John Rigby
[not found] ` <200808052243.24001.arnd@arndb.de>
[not found] ` <4898BCD3.5050703@freescale.com>
[not found] ` <4898BCD3.5050703-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2008-08-05 21:08 ` [PATCH add immr alias 1/4] powerpc: Teach get_immrbase to use immr alias if it exists Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4898C434.4040408@freescale.com \
--to=scottwood-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=jrigby-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox