From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE92AC001DC for ; Fri, 21 Jul 2023 08:21:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231511AbjGUIVi (ORCPT ); Fri, 21 Jul 2023 04:21:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231501AbjGUIVh (ORCPT ); Fri, 21 Jul 2023 04:21:37 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE54C119 for ; Fri, 21 Jul 2023 01:21:34 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-992af8b3b1bso268076266b.1 for ; Fri, 21 Jul 2023 01:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689927693; x=1690532493; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2G6l6gKvH0sa4hNHPgXKsD2m/QNfPKfzJ+aXhMoacwY=; b=nY+d6NkYZWqfsWbKcQP2JItNGldjB+vS+aTA9gDjwywj8jOND6gbyJQa633dXIG2ij fEARasMhaLw8eyiSLJhXkA6Ca0w/lvA4AliC55HVsioCKsCH4FQQwSIZW+UC82sls7sx uBmohcVCtoK/iPE5tSRTaFAmvTaBZ7WLZeYcKLpho0qzmBd4xqSBbJaoXR1arw21Afa7 SL/4swyWEfeTZrq4Vd/T2+gF8J+agb19CQT1vx+Pbd0xuR0d3BEjTEu/3cYNA5Cvmaxd BXV+K684CTT0V7nC549MirV7SXaHaB2t5gCAekPXSFfpTZOaRcwy91nFhWqCdSmb4rZ4 N5sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689927693; x=1690532493; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2G6l6gKvH0sa4hNHPgXKsD2m/QNfPKfzJ+aXhMoacwY=; b=kk0z2v/qKS5Erx1ZYCpx0VfP1/qlDlAJNionjMqs2DOkfI4aX6lr+LBWvwgXnxzuk1 d15RE96eEHRgYvYEH6FrxVqdpRxvIooj9a/7qhXfxD2As3A3mUDyRkwvyyGSPRG6eXyJ eMBOLeSE/+Zx+Dd0uKKfSZvhGd0+naPStQl52Gk5jRAxC3BpOUh0l+cZQuz1QFHTkN4R j352eOx3S1AVTuyHAxvhB7erkcKVSF235vay4UJEhwYOMYY2nCabE6aBaGR0B/IRwx0W ilJXibXKq5YP33A7El9OSZ4HQ8Lv13dyCW/ouUO5hKzA6MZA8L+ICecCAzijapvWIe3E UUxg== X-Gm-Message-State: ABy/qLbYR4UvLuw9GfVWmsOFTePfdgFaiWqVI+eGOLb1Ns1JBCcBMygG kf1RB9VREwFzR+i8gW1wPowVmg== X-Google-Smtp-Source: APBJJlHuviIxegy2LkmpS24DUOOsZ8Etr/86fy83Sp1xWzooLRPFrqeypmf+dHWOFlFSSGMt1f+AJw== X-Received: by 2002:a17:906:5a4e:b0:982:30e3:ddcb with SMTP id my14-20020a1709065a4e00b0098230e3ddcbmr1193586ejc.65.1689927693044; Fri, 21 Jul 2023 01:21:33 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id p24-20020a170906a01800b00992f2befcbcsm1818243ejy.180.2023.07.21.01.21.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 01:21:32 -0700 (PDT) Message-ID: <4898bc33-5245-8fb2-e5e6-8ea1a8f32e1e@linaro.org> Date: Fri, 21 Jul 2023 10:21:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: add mcp4728.yaml Content-Language: en-US To: Andrea Collamati , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <9816cd272d19802ec6eeff0c7c29e85d4a0ade88.1689857295.git.andrea.collamati@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <9816cd272d19802ec6eeff0c7c29e85d4a0ade88.1689857295.git.andrea.collamati@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/07/2023 17:40, Andrea Collamati wrote: > Add documentation for MCP4728 > > Signed-off-by: Andrea Collamati > --- > .../bindings/iio/dac/microchip,mcp4728.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml > > diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml > new file mode 100644 > index 000000000000..6fd9be076245 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/microchip,mcp4728.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip MCP4728 DAC > + > +description: > + MCP4728 is a quad channel, 12-bit voltage output > + Digital-to-Analog Converter with non-volatile > + memory and I2C compatible Serial Interface. > + https://www.microchip.com/en-us/product/mcp4728 > + > +maintainers: > + - Andrea Collamati > + > +properties: > + compatible: > + enum: > + - microchip,mcp4728 This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > + reg: > + maxItems: 1 > + > + vdd-supply: > + description: | > + Provides both power and acts as the reference supply on the MCP4728 > + when Internal Vref is not selected. > + > +required: > + - compatible > + - reg > + - vdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + mcp4728@60 { The same... Probably more comments were ignored, so: This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof