* [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible @ 2024-01-10 10:05 Alexander Stein 2024-02-05 9:19 ` Shawn Guo 2024-02-12 22:35 ` Rob Herring 0 siblings, 2 replies; 4+ messages in thread From: Alexander Stein @ 2024-01-10 10:05 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team, devicetree, linux-arm-kernel, linux Now that there is a dedicated compatible for the idendification page use that instead. This also allows the removal the size and pagesize properties. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi index f6e422dc2663e..9d2328c185c90 100644 --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi @@ -122,10 +122,8 @@ eeprom1: eeprom@57 { /* protectable identification memory (part of M24C64-D @57) */ eeprom@5f { - compatible = "st,24c64", "atmel,24c64"; + compatible = "atmel,24c64d-wl"; reg = <0x5f>; - size = <32>; - pagesize = <32>; vcc-supply = <®_v3v3>; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible 2024-01-10 10:05 [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible Alexander Stein @ 2024-02-05 9:19 ` Shawn Guo 2024-02-12 22:35 ` Rob Herring 1 sibling, 0 replies; 4+ messages in thread From: Shawn Guo @ 2024-02-05 9:19 UTC (permalink / raw) To: Alexander Stein Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam, Pengutronix Kernel Team, NXP Linux Team, devicetree, linux-arm-kernel, linux On Wed, Jan 10, 2024 at 11:05:26AM +0100, Alexander Stein wrote: > Now that there is a dedicated compatible for the idendification page use > that instead. This also allows the removal the size and pagesize > properties. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Applied, thanks! ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible 2024-01-10 10:05 [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible Alexander Stein 2024-02-05 9:19 ` Shawn Guo @ 2024-02-12 22:35 ` Rob Herring 2024-02-14 9:56 ` Alexander Stein 1 sibling, 1 reply; 4+ messages in thread From: Rob Herring @ 2024-02-12 22:35 UTC (permalink / raw) To: Alexander Stein Cc: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam, Pengutronix Kernel Team, NXP Linux Team, devicetree, linux-arm-kernel, linux On Wed, Jan 10, 2024 at 11:05:26AM +0100, Alexander Stein wrote: > Now that there is a dedicated compatible for the idendification page use > that instead. This also allows the removal the size and pagesize > properties. This commit message fails to answer Why? And fails to mention the ABI break. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > index f6e422dc2663e..9d2328c185c90 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > @@ -122,10 +122,8 @@ eeprom1: eeprom@57 { > > /* protectable identification memory (part of M24C64-D @57) */ > eeprom@5f { > - compatible = "st,24c64", "atmel,24c64"; > + compatible = "atmel,24c64d-wl"; This compatible is not documented. Please add it to schema. > reg = <0x5f>; > - size = <32>; > - pagesize = <32>; > vcc-supply = <®_v3v3>; > }; > > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible 2024-02-12 22:35 ` Rob Herring @ 2024-02-14 9:56 ` Alexander Stein 0 siblings, 0 replies; 4+ messages in thread From: Alexander Stein @ 2024-02-14 9:56 UTC (permalink / raw) To: Rob Herring Cc: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam, Pengutronix Kernel Team, NXP Linux Team, devicetree, linux-arm-kernel, linux Hi Rob, thanks for the feedback. Am Montag, 12. Februar 2024, 23:35:01 CET schrieb Rob Herring: > On Wed, Jan 10, 2024 at 11:05:26AM +0100, Alexander Stein wrote: > > Now that there is a dedicated compatible for the idendification page use > > that instead. This also allows the removal the size and pagesize > > properties. > > This commit message fails to answer Why? The original DT entry using the regular "atmel,24c64" compatible is just a workaround. The size and pagesize properties are added to match that dedicated memory block. > And fails to mention the ABI break. Can you elaborate the ABI break? > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > > b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi index > > f6e422dc2663e..9d2328c185c90 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi > > @@ -122,10 +122,8 @@ eeprom1: eeprom@57 { > > > > /* protectable identification memory (part of M24C64-D @57) */ > > eeprom@5f { > > > > - compatible = "st,24c64", "atmel,24c64"; > > + compatible = "atmel,24c64d-wl"; > > This compatible is not documented. Please add it to schema. It already is. Please refer to commit 0997ff1fc1436 ("dt-bindings: at24: add ST M24C64-D Additional Write lockable page"). Thanks, Alexander > > reg = <0x5f>; > > > > - size = <32>; > > - pagesize = <32>; > > > > vcc-supply = <®_v3v3>; > > > > }; -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/ ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-14 9:56 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-01-10 10:05 [PATCH 1/1] arm64: dts: freescale: tqma9352: Update I2C eeprom compatible Alexander Stein 2024-02-05 9:19 ` Shawn Guo 2024-02-12 22:35 ` Rob Herring 2024-02-14 9:56 ` Alexander Stein
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).