Re: [PATCH 1/2] dt-bindings: arm: qcom: split MSM8974 Pro and MSM8974

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 28/11/2022 14:05, Dmitry Baryshkov wrote:
> The MSM8974 Pro (AC) and bare MSM8974 are slightly different platforms.
> Split the compat strings accordingly to clearly specify the platform
> used by the device.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 463509f0f23a..5977b4fdf38e 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -165,14 +165,18 @@ properties:
>  
>        - items:
>            - enum:
> -              - fairphone,fp2
>                - lge,hammerhead
> -              - samsung,klte
>                - sony,xperia-amami
> -              - sony,xperia-castor
>                - sony,xperia-honami
>            - const: qcom,msm8974
>  
> +      - items:
> +          - enum:
> +              - fairphone,fp2
> +              - samsung,klte
> +              - sony,xperia-castor
> +          - const: qcom,msm8974pro

Just like msm8996 this should be followed by qcom,msm8974 from logical
reasons (it is still compatible?) and ABI.


Best regards,
Krzysztof