From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E47E0C433E2 for ; Tue, 8 Sep 2020 08:38:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6CC421D47 for ; Tue, 8 Sep 2020 08:38:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599554333; bh=9MbsarOq+P/4I79z3A+fJ+J72iGu7faVW8HMRIAC4yg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=WAjY2P8d8x1gRgOXCYnhb/pvNP0pb3YKlcvmMomla2lfcGXlB9tKXAea8wjsHlKUZ gvXPeijCcpBTaQp9j9FEsySsODQPkKOlyTc17ZdGngqrNlqTv29KkXjYqaxVduyUsE ofWxOOzjEaQrR5Da/vvnkxJVew1CjzM5xtqXfcsY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729911AbgIHIiw (ORCPT ); Tue, 8 Sep 2020 04:38:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:37072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729564AbgIHIiv (ORCPT ); Tue, 8 Sep 2020 04:38:51 -0400 Received: from [192.168.0.50] (89-70-52-201.dynamic.chello.pl [89.70.52.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A582215A4; Tue, 8 Sep 2020 08:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599554331; bh=9MbsarOq+P/4I79z3A+fJ+J72iGu7faVW8HMRIAC4yg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ABlmjheudFWqMnnqN7fkj7Y8fpGWpqp+Q+5bztrxFGYwdt/wYgY/MV7PHBbVNqkon YKpo8TUVTX6CKqR+9LMrE0vMFmrIIsUlMMIhexMaoFG+3MN9Tu7yuOd+G3uin4Mt/h ku2dg3SQDqNkWUHQcVwN7jdxOTn9U8cssWk6hieU= Subject: Re: [RFT 09/25] ARM: dts: s5pv210: fix number of I2S DAI cells To: Krzysztof Kozlowski , Jonathan Bakker Cc: Kukjin Kim , Rob Herring , Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , =?UTF-8?Q?Pawe=c5=82_Chmiel?= , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org References: <20200907161141.31034-1-krzk@kernel.org> <20200907161141.31034-10-krzk@kernel.org> <20200908065321.GB24227@pi3> From: Sylwester Nawrocki Message-ID: <48aa966f-d3b8-7e4a-36aa-aed4630d331a@kernel.org> Date: Tue, 8 Sep 2020 10:38:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200908065321.GB24227@pi3> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 9/8/20 08:53, Krzysztof Kozlowski wrote: > On Mon, Sep 07, 2020 at 04:55:26PM -0700, Jonathan Bakker wrote: >> Sadly, this is causing issues for me. The machine driver is no longer probing correctly >> on the Galaxy S. >> >> The failing call in sound/soc/samsung/aries_wm8994.c is >> >> /* Set CPU of_node for BT DAI */ >> aries_dai[2].cpus->of_node = of_parse_phandle(cpu, >> "sound-dai", 1); >> >> where cpus->of_node is not set properly. Which is definitely weird because it doesn't >> look like this should affect that. >> >> Let me know if there's any specific test that you want me to do. > Thanks for the tests. I wonder now if this was working before because > really my change should not break it... I'll think more about it. I think of_parse_phandle_with_args() needs to be used instead of just of_parse_phandle() for that to work, as AFAICS the latter assumes the cells count == 0. We would need first to update the driver and then dts.