public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: amitsd@google.com, "Peter Griffin" <peter.griffin@linaro.org>,
	"André Draszik" <andre.draszik@linaro.org>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Badhri Jagan Sridharan <badhri@google.com>
Subject: Re: [PATCH] arm64: dts: exynos: gs101-pixel-common: add supply and regulator properties
Date: Tue, 24 Feb 2026 08:01:23 +0100	[thread overview]
Message-ID: <48d5eb8e-834f-4e87-a59c-d05add0dfda7@kernel.org> (raw)
In-Reply-To: <20260224-max77759-charger-dts-v1-1-b443545c04aa@google.com>

On 24/02/2026 06:03, Amit Sunil Dhamne via B4 Relay wrote:
> From: Amit Sunil Dhamne <amitsd@google.com>
> 
> Add power supply and regulator properties to the MAX77759 pmic. The
> usb-typec device will reference the regulator provided by the pmic as
> it supplies vbus to the typec device when operating in power source mode.
> 
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> ---
> This patch depends on the patchset [1].
> [1] https://lore.kernel.org/all/20260224-max77759-charger-v8-0-eb86bd570e9c@google.com/
> ---
>  arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi b/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> index 93892adaa679..2cc00d34dda8 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-pixel-common.dtsi
> @@ -142,12 +142,13 @@ &hsi2c_12 {
>  	status = "okay";
>  	/* TODO: add the devices once drivers exist */
>  
> -	usb-typec@25 {
> +	maxtcpci: usb-typec@25 {
>  		compatible = "maxim,max77759-tcpci", "maxim,max33359";
>  		reg = <0x25>;
>  		interrupts-extended = <&gpa8 2 IRQ_TYPE_LEVEL_LOW>;
>  		pinctrl-0 = <&typec_int>;
>  		pinctrl-names = "default";
> +		vbus-supply = <&chgin_otg_reg>;
>  
>  		connector {
>  			compatible = "usb-c-connector";
> @@ -236,6 +237,11 @@ pmic@66 {
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  
> +		power-supplies = <&maxtcpci>;

Missing blank line. Please follow DTS coding style.

> +		chgin_otg_reg: chgin-otg-regulator {
> +			regulator-name = "chgin-otg";
> +		};
> +
>  		gpio {
>  			compatible = "maxim,max77759-gpio";
>  
> 
> ---
> base-commit: 8bf22c33e7a172fbc72464f4cc484d23a6b412ba
> change-id: 20260224-max77759-charger-dts-23493398e77c
> 
> Best regards,


Best regards,
Krzysztof

  reply	other threads:[~2026-02-24  7:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24  5:03 [PATCH] arm64: dts: exynos: gs101-pixel-common: add supply and regulator properties Amit Sunil Dhamne via B4 Relay
2026-02-24  7:01 ` Krzysztof Kozlowski [this message]
2026-02-24 21:28   ` Amit Sunil Dhamne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48d5eb8e-834f-4e87-a59c-d05add0dfda7@kernel.org \
    --to=krzk@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=amitsd@google.com \
    --cc=andre.draszik@linaro.org \
    --cc=badhri@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox