From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E02C7C352A1 for ; Wed, 7 Dec 2022 12:31:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229838AbiLGMbl (ORCPT ); Wed, 7 Dec 2022 07:31:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229797AbiLGMbi (ORCPT ); Wed, 7 Dec 2022 07:31:38 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87EB84EC0A for ; Wed, 7 Dec 2022 04:31:36 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id x28so11127550lfn.6 for ; Wed, 07 Dec 2022 04:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j1GOf3uEYk8gTP9XDz9QwwuKudeT3AfYAf9a/Xk700A=; b=P7t6NaUWtotLXSAGzeYK7qYNyTh2B/hx31CNgaQresmr3i/q0/RKP+a2WJCEEihW9s I/KwIk3MtOymKoVE2Huxz3knCMmsAC1oxWJhdTGjXSvqhhaFfhVNoPsFLDjjAIu1Getd yWqmuD5q3dcyecG/cjx4gACfebiE5DGJQvL9yaXdlT49yjhZ/0IF5fB+1QbZbvifSFOL tOJCi/KjzG5WqNmzyyW+5WIL1WJqkHZM8Yf3BRfT+6tGQecC0hSACGE5mGIEJg8ndLq7 EXc1U8k6e5kTKvg/ohhY36eJnKEgWam0ahTWW9FOgleOlgXQIp/srLnqcUxlVUuun/eb cWXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j1GOf3uEYk8gTP9XDz9QwwuKudeT3AfYAf9a/Xk700A=; b=X9JagrLXMUQNQ/piLiQVmKVVAnZ2xfGZ7d+fr4cZW7DIVwJuLQvr+cRup8vCvnI0OO D1F5CmFkdZs6a40PF/ahHQjFfQU3vXyGd84D8T74aZOR06Xzk3/1MDO2r+nV3tvey6zK QDrztvzHuAXyOso77GjO7aRRL3nl5WbK/HwRGjBXcRsRWH5AR8b2cRBoCyINKaCBVItq aSFp06rMEjuovabsSE3DdWtgIlPXSPkP3LQQjnSbVAMCMLPH4Dy4gZ2zkbiVbJi1A/dk 7tjCeOyCMI5+aDKT1gMLlhiovyrkzqtQv3CJ2M7bCqWgBRL3MMMO68+tvzq5O/wFw1zF KiBw== X-Gm-Message-State: ANoB5plLDwTz6dcZhmLXbMY13CNPve7XBu86w8SgpAQvPDekeGLBrJ6l QMTGdWOy1koXUwuB5mlSfip3uA== X-Google-Smtp-Source: AA0mqf7Ipmnr9eW6KJgrSxw94wK1rZlICewLntr4O6muD0J4UwxoJ73JVR1oT8JeaJBIG01l4gvxEg== X-Received: by 2002:a05:6512:150:b0:4ae:6c29:d043 with SMTP id m16-20020a056512015000b004ae6c29d043mr26776442lfo.474.1670416294784; Wed, 07 Dec 2022 04:31:34 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id o18-20020a05651205d200b004b5323639d8sm2823837lfo.155.2022.12.07.04.31.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Dec 2022 04:31:34 -0800 (PST) Message-ID: <48d60bd0-4de1-4a5e-eca1-1f8a9303cce0@linaro.org> Date: Wed, 7 Dec 2022 13:31:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v11 5/6] dt-bindings: media: wave5: add yaml devicetree bindings Content-Language: en-US To: Sebastian Fricke , linux-media@vger.kernel.org, Rob Herring , Krzysztof Kozlowski Cc: kernel@collabora.com, bob.beckett@collabora.com, hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com, nas.chung@chipsnmedia.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221207121350.66217-1-sebastian.fricke@collabora.com> <20221207121350.66217-6-sebastian.fricke@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <20221207121350.66217-6-sebastian.fricke@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/12/2022 13:13, Sebastian Fricke wrote: > From: Robert Beckett > > Add bindings for the wave5 chips&media codec driver > > Signed-off-by: Robert Beckett > Signed-off-by: Dafna Hirschfeld > Signed-off-by: Sebastian Fricke What's happening with this patch? Where is the changelog? Why it is v11 and first time I see it? And why it is v11 with basic mistakes and lack of testing?!? I would assume that v11 was already seen and tested... > --- > .../devicetree/bindings/cnm,wave5.yml | 72 +++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 Documentation/devicetree/bindings/cnm,wave5.yml Wrong directory. It wasn't here at all before, so I am really confused how this could happen. Subject: drop redundant pieces: yaml, devicetree and bindings. > > diff --git a/Documentation/devicetree/bindings/cnm,wave5.yml b/Documentation/devicetree/bindings/cnm,wave5.yml > new file mode 100644 > index 000000000000..01dddebb162e > --- /dev/null > +++ b/Documentation/devicetree/bindings/cnm,wave5.yml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/wave5.yaml# You clearly did not test them before sending. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Chips&Media Wave 5 Series multi-standard codec IP > + > +maintainers: > + - Nas Chung > + - Robert Beckett > + - Sebastian Fricke > + > +description: |- > + The Chips&Media WAVE codec IP is a multi format video encoder/decoder > + > +properties: > + compatible: > + anyOf: Please start from example-schema or other recently approved bindings. No anyOf. > + - items: No items... > + - enum: > + - cnm,cm511-vpu > + - cnm,cm517-vpu > + - cnm,cm521-vpu > + - cnm,cm521c-vpu > + - cnm,cm521c-dual-vpu What's the difference between this and one above? > + - cnm,cm521e1-vpu > + - cnm,cm537-vpu > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + maxItems: 4 This has to be specific. > + > + clock-names: > + minItems: 1 > + maxItems: 4 You need to list the names. > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + sram: Missing vendor prefix. > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle pointing to the SRAM device node And what is it for? Why do you need SRAM? > + maxItems: 1 Drop > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + vpu: video-codec@12345678 { > + compatible = "cnm,cm521-vpu"; > + reg = <0x12345678 0x1000>; > + interrupts = <42>; > + clocks = <&clks 42>; > + clock-names = "vcodec"; > + sram = <&sram>; > + }; Best regards, Krzysztof