From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F308224CF for ; Thu, 14 Sep 2023 08:56:08 +0000 (UTC) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 431AE2101 for ; Thu, 14 Sep 2023 01:56:07 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4013454fa93so8020765e9.0 for ; Thu, 14 Sep 2023 01:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694681765; x=1695286565; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ptKSXFKL7hUlaoL1cb/s1P95ZG9Kvuda4CmpMRlx4cc=; b=qVGgcxYIWJVDxlXHemU529FOxglX1XBDW+LNZQ/eBXl8Gt2E4ND9hCYtqb+z4q9/58 gcmBbJ0+hNNVVPrzzwrMEYWi7XqoRWanOlnBoonyNlsEi/iKRU299Hq1QDxw0W91eCC5 fFTipUhgGDyHhRjXKLGXkWtiJMNTswNXf1KIhYImYYB+y2K350o2yhKLL6/JFB2e+pYd eNhpJWzg3vkTwoqNKJrvYFUl6ZrsbcDA/wQElf+UcAxHbjMIjQ920rHvOlSCR2ikuwoc HcZiXDyJP97virdBMgKRfrPVMjbUtSTWfpUUOfWBL9cStvorZNFNRmMXSotjhv4kGWDc KVuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694681765; x=1695286565; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ptKSXFKL7hUlaoL1cb/s1P95ZG9Kvuda4CmpMRlx4cc=; b=P3Ird/ea/oBejjXt6hfP2Sq9u6Qak6ed2c69+WOPECK8MMYYAgXxouHbEsm4ND5KCI GGEEx7AdjHOlSsCMWUrecSqly73Uw7sfHidNvx4EnO2Aa7mVt9QF4v/AdHaaAyFAVhP2 a0e8CRXqHqtFNFrNiEGBXOBb3hRQX3Qi6MahrIeqjhPQEUYeGCMcw9zM6SI6z96aj8di 7L8lQ6tmy/1zTSqvgmJFwC/cAIRQAXf8ap820DB2/TRITCeNHCVfmQjlCikdgkF5YZ1p 7A2PXnrixDM+siw9VF9NFx8I2DIEb2fgMVI9Rh6OA665MGlnco6g7ZIQifdEt/x68eQl 4e7w== X-Gm-Message-State: AOJu0Yy4dVCnv2Y7asnxe6MnJo6R+93E2+rIBGy1uDgNIr79LoqTxkRX O2Dnj35Xko6MlnqtN4lwd9ToqA== X-Google-Smtp-Source: AGHT+IFxM+i9nRno0Y6ZWNHABTz+IL2NvLFiF8Qm7rB7Thevu96BEPRowS1CgLyPGPbezTxD4TDAqw== X-Received: by 2002:a5d:6952:0:b0:319:55bc:4416 with SMTP id r18-20020a5d6952000000b0031955bc4416mr4368224wrw.5.1694681765604; Thu, 14 Sep 2023 01:56:05 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id a4-20020adffb84000000b0031c5ce91ad6sm1146486wrr.97.2023.09.14.01.56.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Sep 2023 01:56:05 -0700 (PDT) Message-ID: <48e46de0-0996-b715-9d17-e1e10c0e44be@linaro.org> Date: Thu, 14 Sep 2023 10:56:01 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 3/5] gpio: vf610: add i.MX8ULP of_device_id entry To: Linus Walleij Cc: "Peng Fan (OSS)" , Bartosz Golaszewski , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan References: <20230914-vf610-gpio-v1-0-3ed418182a6a@nxp.com> <20230914-vf610-gpio-v1-3-3ed418182a6a@nxp.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 14/09/2023 10:48, Linus Walleij wrote: > On Thu, Sep 14, 2023 at 7:48 AM Krzysztof Kozlowski > wrote: >> On 14/09/2023 04:20, Peng Fan (OSS) wrote: >>> From: Peng Fan >>> >>> i.MX8ULP supports two interrupts, while i.MX7ULP supports one interrupt. >>> So from hardware perspective, they are not compatible. >>> >>> So add entry for i.MX8ULP. >>> >>> Signed-off-by: Peng Fan >>> --- >>> drivers/gpio/gpio-vf610.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c >>> index dbc7ba0ee72c..88f7215cdf4b 100644 >>> --- a/drivers/gpio/gpio-vf610.c >>> +++ b/drivers/gpio/gpio-vf610.c >>> @@ -67,6 +67,7 @@ static const struct fsl_gpio_soc_data imx_data = { >>> static const struct of_device_id vf610_gpio_dt_ids[] = { >>> { .compatible = "fsl,vf610-gpio", .data = NULL, }, >>> { .compatible = "fsl,imx7ulp-gpio", .data = &imx_data, }, >>> + { .compatible = "fsl,imx8ulp-gpio", .data = &imx_data, }, >> >> Why? It is the same as imx7. No need. > > Because compatible = "fsl,imx7ulp-gpio" is not what is going to be in the > device tree, but compatible = "fsl,imx8ulp-gpio"? > > What am I missing here? Maybe the commit message is weird. > If the devices used before and are still going to use same driver data, they look compatible from OS point of view. Therefore usually we express such compatibility and do not add unneeded device_id entries. Now whether the devices are truly compatible or not, I don't know and with some recent emails I am bit confused. Best regards, Krzysztof