Re: [PATCH 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

Krzysztof Kozlowski
2024-11-21T16:21:54Z

On 21/11/2024 16:56, Kryštof Černý wrote:
>
>
> Dne 21.11.2024 v 8:43 Krzysztof Kozlowski napsal(a):
>> On 20/11/2024 23:53, Kryštof Černý wrote:
>>> Hello,
>>>
>>>> On 20/11/2024 09:34, Kryštof Černý wrote:
>>>>> Hello,
>>>>>
>>>>>> On Fri, Nov 15, 2024 at 03:58:06PM +0100, Kryštof Černý via B4 Relay wrote:
>>>>>>> From: Kryštof Černý <cleverline1mc@gmail.com>
>>>>>>>
>>>>>>> Adds the newly added vcc-supply property to bindings.
>>>>>>
>>>>>> This commit message is a circular argument. You're adding it to the
>>>>>> binding, which of course means it is newly added.
>>>>>
>>>>> You are right, I will replace with "Adds the vcc-supply property to
>>>>> bindings." in the next version.
>>>>
>>>> No, please say why, e.g. because it was missing and device has it
>>>> according to datasheet.
>>>
>>> Right, what about:
>>>
>>> Adds the optional vcc-supply property to bindings, informs if the device
>>> needs a regulator to be turned on for its operation
>>
>> It does not inform at all. All devices needs power, don't they? And what
>> operation?
>
> This is probably the best I can do:
>
> ds2482 has a VCC pin, accepting 2.9-5.5 V. Allow optionally specifying
> a voltage regulator to power the chip.

Keep only first sentence. Second is obvious, no need to repeat schema in
free form text (and schema defines it is optional).

Best regards,
Krzysztof