Re: [PATCH 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

Conor Dooley
2024-11-15T18:16:36Z

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

On Fri, Nov 15, 2024 at 03:58:06PM +0100, Kryštof Černý via B4 Relay wrote:
> From: Kryštof Černý <cleverline1mc@gmail.com>
>
> Adds the newly added vcc-supply property to bindings.

This commit message is a circular argument. You're adding it to the
binding, which of course means it is newly added.

>
> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
> ---
> Documentation/devicetree/bindings/w1/maxim,ds2482.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> index 422becc6e1fa8d58665c5586ebdc611cd0b2c760..a6b9e0658ec858cb24b21cf64443a061bb43e4ef 100644
> --- a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> +++ b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
> @@ -25,6 +25,9 @@ properties:
> reg:
> maxItems: 1
>
> + vcc-supply:
> + description: phandle of the regulator that provides the supply voltage.

"vcc-supply: true" should suffice.

> +
> required:
> - compatible
> - reg
>
> --
> 2.39.5
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]