From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 3/4] of/platform: fix device naming for non-translatable addresses Date: Thu, 08 May 2014 15:15:07 +0200 Message-ID: <4916948.fjAQXx11x1@wuerfel> References: <1399499298-8830-1-git-send-email-robherring2@gmail.com> <4314054.Zr5Mecf9vm@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Grant Likely , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Ivan T. Ivanov" , Josh Cartwright , Courtney Cavin , Bjorn Andersson , Frank Rowand List-Id: devicetree@vger.kernel.org On Thursday 08 May 2014 07:55:06 Rob Herring wrote: > On Thu, May 8, 2014 at 5:41 AM, Arnd Bergmann wrote: > > On Wednesday 07 May 2014 16:48:17 Rob Herring wrote: > >> From: Rob Herring > >> > >> Using non-translatable addresses in platform device names is wrong > >> because they may not be globally unique. Just use the default naming with > >> a global index if the address cannot be translated instead. > >> > >> of_can_translate_address has the same checks as of_translate_address, so > >> we can remove it here as well. > > > > Have you checked that this doesn't break platforms using clkdev lookup > > based on names with local addresses? It's quite possible that nobody > > does that, but it would be good to have someone confirm it. > > I had not, but now I have. There don't appear to be any cases of that. Ok, thanks for checking. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html