From: "Rafał Miłecki" <rafal@milecki.pl>
To: William Zhang <william.zhang@broadcom.com>
Cc: Linux ARM List <linux-arm-kernel@lists.infradead.org>,
joel.peshkin@broadcom.com, dan.beygelman@broadcom.com,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Anand Gore <anand.gore@broadcom.com>,
Kursad Oney <kursad.oney@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 5/9] arm64: dts: Add BCM4908 generic board dts
Date: Thu, 21 Jul 2022 08:45:54 +0200 [thread overview]
Message-ID: <4919ef26ece22db845de584e3d9b3814@milecki.pl> (raw)
In-Reply-To: <20220721000731.29597-1-william.zhang@broadcom.com>
On 2022-07-21 02:07, William Zhang wrote:
> Add generic bcm94908.dts file.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---
>
> arch/arm64/boot/dts/broadcom/bcmbca/Makefile | 1 +
> .../boot/dts/broadcom/bcmbca/bcm94908.dts | 30 +++++++++++++++++++
> 2 files changed, 31 insertions(+)
> create mode 100644 arch/arm64/boot/dts/broadcom/bcmbca/bcm94908.dts
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
> b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
> index d30fa75f0611..27741b71ba9e 100644
> --- a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
> +++ b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile
> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_BCMBCA) += \
> bcm4906-tplink-archer-c2300-v1.dtb \
> bcm4908-asus-gt-ac5300.dtb \
> bcm4908-netgear-raxe500.dtb \
> + bcm94908.dtb \
> bcm4912-asus-gt-ax6000.dtb \
> bcm94912.dtb \
> bcm963158.dtb \
AFAIU bcm94908 is a reference board name. I think I see some
inconsistency in naming Broadcom's reference boards DTS files.
If you take a look at in-kernel DTS files:
find ./arch/arm*/boot/dts/ -name "*.dts"
99% of them are prefixed with family/SoC name. I did the same for
bcm4908 (and Northstar) boards. So it's
<soc>-<manufacturer>-<model>.dts
e.g.
bcm4908-asus-gt-ac5300.dts
To match that I *think* you should actually call your file:
bcm4908-bcm94908 (or bcm4908-94908 depending on actual board name)
First of all: am I correct here?
Secondly: could you do that? I know many DTS files named ignoring SoC/
family prefix. Still maybe we could change it as some (this) point?
next prev parent reply other threads:[~2022-07-21 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 0:07 [RESEND PATCH 5/9] arm64: dts: Add BCM4908 generic board dts William Zhang
2022-07-21 6:45 ` Rafał Miłecki [this message]
2022-07-21 18:29 ` William Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4919ef26ece22db845de584e3d9b3814@milecki.pl \
--to=rafal@milecki.pl \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=joel.peshkin@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).