Re: [PATCH 2/7] mailbox: keembay-scmi-mailbox: Add support for Keem Bay mailbox

[Daniele Alessandrelli <daniele.alessandrelli@linux.intel.com>]

Hi Sudeep,

Thanks for your review.

On Wed, 2020-07-08 at 21:34 +0100, Sudeep Holla wrote:
> On Tue, Jun 16, 2020 at 04:56:08PM +0100, Daniele Alessandrelli
> wrote:
> > From: Paul Murphy <paul.j.murphy@intel.com>
> > 
> > Keem Bay SoC has a ARM trusted firmware-based secure monitor which
> > acts
> > as the SCP for the purposes of power management over SCMI.
> > 
> > This driver implements the transport layer for SCMI to function.
> > 
> 
> Please use the smc transport support in
> driver/firmware/arm_scmi/smc.c
> for this. You don't need mailbox support for SMC/HVC. Basically you
> don't need this driver at all and you have everything you need to
> support
> what you want.
> 
> Let me know if you face issues.
> 

Sorry, we didn't know about the SMC transport support for SCMI. Looks
like it was added only recently, while our driver was already developed
and waiting to be upstreamed.

I agree that we can drop this driver and switch to the SMC transport as
you suggested, but I think we'll have to modify our bootloader SiP
service slightly. Paul, can you elaborate?

Regards,
Daniele