From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52652CCA47B for ; Fri, 10 Jun 2022 20:48:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347296AbiFJUr7 (ORCPT ); Fri, 10 Jun 2022 16:47:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347010AbiFJUr6 (ORCPT ); Fri, 10 Jun 2022 16:47:58 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3747613CC1 for ; Fri, 10 Jun 2022 13:47:55 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id a15so262748lfb.9 for ; Fri, 10 Jun 2022 13:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=8KwPXLp0XOa90G9moFXqn+YK8bv+iSnrOMIWn8R44VQ=; b=xPKDjHkdR6DyCfEtwgkAI9p1egmcpidgHgRAETIYUaYNWDTftQ10fVeR9XpKUOyx0W hmv+ZDivua7J/iHC9pJjch+MuKkPKwRtNZikeb2xyA2cwmtYhQwmfXL50wsBtHU7Nmq3 vpLe3SrZeYxCwIn/p9X377ItMLHC4sWZwOEmEkaHxw3qmMZRB9p3ajbXgnkV4FqjKGqj bl5cG5lWfe/+gMMVJmd5JkFOkeWtWi4ntC/q3+jwv1L3PdYRzs7n7118Z3K2ukzRed9h U2j5qhnN33hu3uTXYF0BFfMDWetDcTeTSbB2ZuVV2wflkOmQ/CL5w6+wAIvX6MJ8kKvJ bJMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=8KwPXLp0XOa90G9moFXqn+YK8bv+iSnrOMIWn8R44VQ=; b=dqsyLyXiMy9ji9ngwdOyCpMIqzrdEVO+rYiTzxuSJUephE5rmw9Jcm9L0a2xNvY0qF QM+aNBJJzMMT2XhcUCHZxUrmX3sx9/8jLY896JunwRidLNOUoSprYAf1mmH88tukjwPU RCCfh4G/6nmwrO0T1XlfpODAX6O8x6crIIQd4PRzjO5wliS7ZeFjLnfxaWxOocIZcei7 ttfqKPC5nZYg0BfuWU7bz8haqb4vselCQkRit4WBymJHkK3AvZNoeZbdGbDuukj9sGNR 7qdJShEsrsS0cq/rotBifNFb7MkiiapSP3E/rNadrnIOjcEZZ2vu00x8S5KkFQJqliMx mwRw== X-Gm-Message-State: AOAM530B3MONwTIp9JBTntmtj09LuXV5VLY8MA4uVRQZDzkZwTL97Go8 CTyKfBYzRfS1A2nw4LQy/142iA== X-Google-Smtp-Source: ABdhPJyOLAZ0DtqDYs7mIgFCiYwqsPd9FGnhF38NRQy2k3tH+rhfLOxamV0FdLf2aYVUy+utRDdMxg== X-Received: by 2002:a05:6512:32b2:b0:479:b04:c0af with SMTP id q18-20020a05651232b200b004790b04c0afmr28576044lfe.384.1654894073576; Fri, 10 Jun 2022 13:47:53 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id p26-20020a2ea41a000000b002557c48cc4csm62393ljn.95.2022.06.10.13.47.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 13:47:52 -0700 (PDT) Message-ID: <492bbe98-e395-3adb-34e3-eadccd59d849@linaro.org> Date: Fri, 10 Jun 2022 23:47:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 06/14] drm/msm/hdmi: drop unused GPIO support Content-Language: en-GB To: Stephen Boyd , Abhinav Kumar , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Rob Clark , Rob Herring , Sean Paul Cc: David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, kernel test robot References: <20220609122350.3157529-1-dmitry.baryshkov@linaro.org> <20220609122350.3157529-7-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/06/2022 23:46, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022-06-09 05:23:42) >> The HDMI driver has code to configure extra GPIOs, which predates >> pinctrl support. Nowadays all platforms should use pinctrl instead. >> Neither of upstreamed Qualcomm platforms uses these properties, so it's >> safe to drop them. >> >> Reported-by: kernel test robot >> Signed-off-by: Dmitry Baryshkov >> --- > > One question > > Reviewed-by: Stephen Boyd > >> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c >> index 7267167d5ef1..6d79f1b910a5 100644 >> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c >> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c >> @@ -233,6 +233,20 @@ static struct hdmi *msm_hdmi_init(struct platform_device *pdev) >> hdmi->pwr_clks[i] = clk; >> } >> >> + hdmi->hpd_gpiod = devm_gpiod_get_optional(&pdev->dev, "hpd", GPIOD_IN); >> + /* This will catch e.g. -EPROBE_DEFER */ >> + if (IS_ERR(hdmi->hpd_gpiod)) { >> + ret = PTR_ERR(hdmi->hpd_gpiod); >> + DRM_DEV_ERROR(&pdev->dev, "failed to get hpd gpio: (%d)\n", ret); > > Did you want to print an error with eprobe defer in it? True. We should use dev_err_probe here. I'll fix it in the next revision. > >> + goto fail; >> + } >> + >> + if (!hdmi->hpd_gpiod) >> + DBG("failed to get HPD gpio"); >> + >> + if (hdmi->hpd_gpiod) >> + gpiod_set_consumer_name(hdmi->hpd_gpiod, "HDMI_HPD"); >> + >> pm_runtime_enable(&pdev->dev); >> >> hdmi->workq = alloc_ordered_workqueue("msm_hdmi", 0); -- With best wishes Dmitry