From: Krzysztof Kozlowski <krzk@kernel.org>
To: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Tipton <mike.tipton@oss.qualcomm.com>
Subject: Re: [PATCH 1/3] dt-bindings: interconnect: add clocks property to enable QoS on qcs8300
Date: Sat, 29 Nov 2025 10:45:36 +0100 [thread overview]
Message-ID: <4930a0ad-258c-45ea-99a0-753cb3c3ba6b@kernel.org> (raw)
In-Reply-To: <20251128150106.13849-2-odelu.kukatla@oss.qualcomm.com>
On 28/11/2025 16:01, Odelu Kukatla wrote:
> Add 'clocks' property to enable QoS configuration. This property
> enables the necessary clocks for QoS configuration.
>
> QoS configuration is essential for ensuring that latency sensitive
> components such as CPUs and multimedia engines receive prioritized
> access to memory and interconnect resources. This helps to manage
> bandwidth and latency across subsystems, improving system responsiveness
> and performance in concurrent workloads.
Same problems with your previous and other commits:
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
"on qcs8300" is redundant. Prefix defines that, so use proper prefixes.
You do not add clocks for every interconnect...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-29 9:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 15:01 [PATCH 0/3] Enable QoS configuration on QCS8300 Odelu Kukatla
2025-11-28 15:01 ` [PATCH 1/3] dt-bindings: interconnect: add clocks property to enable QoS on qcs8300 Odelu Kukatla
2025-11-28 16:19 ` Rob Herring (Arm)
2025-11-29 9:33 ` Krzysztof Kozlowski
2025-11-29 9:37 ` Krzysztof Kozlowski
2025-12-22 17:38 ` Odelu Kukatla
2025-12-23 13:45 ` Krzysztof Kozlowski
2026-01-03 18:42 ` Odelu Kukatla
2025-11-29 9:45 ` Krzysztof Kozlowski [this message]
2025-12-22 17:45 ` Odelu Kukatla
2025-12-23 19:55 ` Dmitry Baryshkov
2025-12-24 10:59 ` Odelu Kukatla
2025-11-28 15:01 ` [PATCH 2/3] interconnect: qcom: qcs8300: enable QoS configuration Odelu Kukatla
2025-11-29 1:20 ` Dmitry Baryshkov
2025-12-01 15:06 ` Konrad Dybcio
2025-11-28 15:01 ` [PATCH 3/3] arm64: dts: qcom: qcs8300: Add clocks for " Odelu Kukatla
2025-11-29 1:16 ` Dmitry Baryshkov
2025-11-29 9:34 ` Krzysztof Kozlowski
2025-12-22 16:57 ` Odelu Kukatla
2025-12-01 15:09 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4930a0ad-258c-45ea-99a0-753cb3c3ba6b@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mike.tipton@oss.qualcomm.com \
--cc=odelu.kukatla@oss.qualcomm.com \
--cc=raviteja.laggyshetty@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox