* [PATCH] dt-bindings: leds: Document "rc-feedback" trigger
@ 2024-10-07 16:08 Heiko Stuebner
2024-10-07 18:01 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2024-10-07 16:08 UTC (permalink / raw)
To: lee; +Cc: robh, krzk+dt, conor+dt, linux-leds, devicetree, linux-kernel,
heiko
Document the "rc-feedback" trigger which is used to control LEDs by
remote control device activity. This is an existing trigger used in
existing DTs, document it so validation of those DTs would pass.
It was originally introduced into the Linux kernel in 2013 with
commit 153a60bb0fac ("[media] rc: add feedback led trigger for rc keypresses")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
Documentation/devicetree/bindings/leds/common.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index bf9a101e4d42..32f9116e03a2 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -119,6 +119,8 @@ properties:
# if trigger is absent
- none
# LED indicates camera torch state
+ - rc-feedback
+ # LED indicates remote control feedback
- torch
# LED indicates USB gadget activity
- usb-gadget
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: leds: Document "rc-feedback" trigger
2024-10-07 16:08 [PATCH] dt-bindings: leds: Document "rc-feedback" trigger Heiko Stuebner
@ 2024-10-07 18:01 ` Pavel Machek
2024-10-07 20:52 ` Heiko Stübner
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2024-10-07 18:01 UTC (permalink / raw)
To: Heiko Stuebner
Cc: lee, robh, krzk+dt, conor+dt, linux-leds, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
On Mon 2024-10-07 18:08:04, Heiko Stuebner wrote:
> Document the "rc-feedback" trigger which is used to control LEDs by
> remote control device activity. This is an existing trigger used in
> existing DTs, document it so validation of those DTs would pass.
>
> It was originally introduced into the Linux kernel in 2013 with
> commit 153a60bb0fac ("[media] rc: add feedback led trigger for rc keypresses")
> index bf9a101e4d42..32f9116e03a2 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -119,6 +119,8 @@ properties:
> # if trigger is absent
> - none
> # LED indicates camera torch state
> + - rc-feedback
> + # LED indicates remote control feedback
> - torch
> # LED indicates USB gadget activity
> - usb-gadget
NAK. Wrongly placed comment.
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: leds: Document "rc-feedback" trigger
2024-10-07 18:01 ` Pavel Machek
@ 2024-10-07 20:52 ` Heiko Stübner
0 siblings, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2024-10-07 20:52 UTC (permalink / raw)
To: Pavel Machek
Cc: lee, robh, krzk+dt, conor+dt, linux-leds, devicetree,
linux-kernel
Am Montag, 7. Oktober 2024, 20:01:27 CEST schrieb Pavel Machek:
> On Mon 2024-10-07 18:08:04, Heiko Stuebner wrote:
> > Document the "rc-feedback" trigger which is used to control LEDs by
> > remote control device activity. This is an existing trigger used in
> > existing DTs, document it so validation of those DTs would pass.
> >
> > It was originally introduced into the Linux kernel in 2013 with
> > commit 153a60bb0fac ("[media] rc: add feedback led trigger for rc keypresses")
>
> > index bf9a101e4d42..32f9116e03a2 100644
> > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > @@ -119,6 +119,8 @@ properties:
> > # if trigger is absent
> > - none
> > # LED indicates camera torch state
> > + - rc-feedback
> > + # LED indicates remote control feedback
> > - torch
> > # LED indicates USB gadget activity
> > - usb-gadget
>
> NAK. Wrongly placed comment.
you're right, and it even messed up the torch comment + entry
Will send a v2
Heiko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-07 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 16:08 [PATCH] dt-bindings: leds: Document "rc-feedback" trigger Heiko Stuebner
2024-10-07 18:01 ` Pavel Machek
2024-10-07 20:52 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).