From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stephan Gerhold <stephan.gerhold@kernkonzept.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sireesh Kodali <sireeshkodali1@gmail.com>,
Luca Weiss <luca@z3ntu.xyz>,
Stephan Gerhold <stephan@gerhold.net>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/6] arm64: dts: qcom: msm8916: Drop MSS fallback compatible
Date: Thu, 14 Jul 2022 11:45:27 +0200 [thread overview]
Message-ID: <4936df27-e5b5-8ef5-5831-82fdf414ea90@linaro.org> (raw)
In-Reply-To: <20220712124421.3129206-2-stephan.gerhold@kernkonzept.com>
On 12/07/2022 14:44, Stephan Gerhold wrote:
> MSM8916 was originally using the "qcom,q6v5-pil" compatible for the
> MSS remoteproc. Later it was decided to use SoC-specific compatibles
> instead, so "qcom,msm8916-mss-pil" is now the preferred compatible.
>
> Commit 60a05ed059a0 ("arm64: dts: qcom: msm8916: Add MSM8916-specific
> compatibles to SCM/MSS") updated the MSM8916 device tree to make use of
> the new compatible but still kept the old "qcom,q6v5-pil" as fallback.
>
> This is inconsistent with other SoCs and conflicts with the description
> in the binding documentation (which says that only one compatible should
> be present). Also, it has no functional advantage since older kernels
> could not handle this DT anyway (e.g. "power-domains" in the MSS node is
> only supported by kernels that also support "qcom,msm8916-mss-pil").
>
> Make this consistent with other SoCs by using only the
> "qcom,msm8916-mss-pil" compatible.
>
> Fixes: 60a05ed059a0 ("arm64: dts: qcom: msm8916: Add MSM8916-specific compatibles to SCM/MSS")
> Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-14 9:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 12:44 [PATCH 0/6] remoteproc: qcom_q6v5_mss: Add MSM8909 Stephan Gerhold
2022-07-12 12:44 ` [PATCH 1/6] arm64: dts: qcom: msm8916: Drop MSS fallback compatible Stephan Gerhold
2022-07-14 9:45 ` Krzysztof Kozlowski [this message]
2022-07-12 12:44 ` [PATCH 2/6] dt-bindings: remoteproc: qcom,q6v5: Move MSM8916 to schema Stephan Gerhold
2022-07-12 14:26 ` Rob Herring
2022-07-14 9:50 ` Krzysztof Kozlowski
2022-07-14 18:48 ` Stephan Gerhold
2022-07-15 6:33 ` Krzysztof Kozlowski
2022-07-15 8:00 ` Stephan Gerhold
2022-07-15 8:09 ` Krzysztof Kozlowski
2022-07-12 12:44 ` [PATCH 3/6] ARM: dts: qcom: msm8974: Disable remoteprocs by default Stephan Gerhold
2022-07-14 9:55 ` Krzysztof Kozlowski
2022-07-14 19:01 ` Stephan Gerhold
2022-07-15 6:44 ` Krzysztof Kozlowski
2022-07-17 3:08 ` (subset) " Bjorn Andersson
2022-07-12 12:44 ` [PATCH 4/6] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8974 Stephan Gerhold
2022-07-14 9:56 ` Krzysztof Kozlowski
2022-07-12 12:44 ` [PATCH 5/6] dt-bindings: remoteproc: qcom,q6v5-pil: Add MSM8909 Stephan Gerhold
2022-07-14 9:57 ` Krzysztof Kozlowski
2022-07-12 12:44 ` [PATCH 6/6] remoteproc: qcom_q6v5_mss: Add support for MSM8909 Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4936df27-e5b5-8ef5-5831-82fdf414ea90@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sireeshkodali1@gmail.com \
--cc=stephan.gerhold@kernkonzept.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).