From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 01/10] ARM: NUC900: Add nuc970 machine support Date: Mon, 11 Jul 2016 00:11:31 +0200 Message-ID: <4947302.8IpnGALVQ9@wuerfel> References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1468135649-19980-2-git-send-email-vw@iommu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1468135649-19980-2-git-send-email-vw@iommu.org> Sender: linux-clk-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: Wan Zongshun , Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, jason@lakedaemon.net, Daniel Lezcano , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun List-Id: devicetree@vger.kernel.org On Sunday, July 10, 2016 3:27:21 PM CEST Wan Zongshun wrote: > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +static void __init nuc900_machine_init(void) > +{ > + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > +} This is the default for .init_machine, so you can leave the function undefined. > +static const char *nuc900_dt_compat[] __initconst = { > + "nuvoton,nuc970", > + NULL, > +}; > + > +DT_MACHINE_START(nuc900_dt, "Nuvoton NUC900 (Device Tree Support)") > + .init_machine = nuc900_machine_init, > + .dt_compat = nuc900_dt_compat, > +MACHINE_END > After that, you can probably remove most of the #include statements. The file is still needed for now, until you move to ARCH_MULTIPLATFORM, at which point the entire machine descriptor is redundant. Arnd