From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1963F219A6C; Thu, 5 Dec 2024 15:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733412157; cv=none; b=n1Y5COmPh/8MpYUo2o9PS6YQ2IogPdsOq5ZalCPAtZBluu7vCdTZMyLNoYOnmdLCgbLmhLnJAE2pG6BcLF0NTzMB0yYUl+kLFWwR/wcQGBtct45KkjebiavPIUJwPD0sXjDTa9xaFE3lSRCyeff07smJmk8an70hPNE9Kj3HDbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733412157; c=relaxed/simple; bh=WUv8DIfvaOrg5xzRIwFyNjV1vbHABHoRXf3mFeWDKVQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HrTecFzL8DTDyk/cypaP6uxqRrMlcyh6xHYW6Px/YitL01Xu2S8d3uX5SGKoVWD5J4g3cAj+GftkLlYPa+WeVtVGTaCDIpz/E+OxmNtldJd7OQMj/KakE5dGmJJPwbSqcj3jVPstl3lMXrec1mVOCjB8b1z77BxndrQsL6Bi8/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=UCE2bKer; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=KHXc9JZX reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="UCE2bKer"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="KHXc9JZX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1733412153; x=1764948153; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OgpqTYmx1JwJV2MXhL2h0e8cSJoFw6QERgxshp0L/wQ=; b=UCE2bKeroNkgMIM1TQc1O5JQXtGcel3ZeZHXxp8s60zoUipgU68PfnxG egn270suPQJj2EVrl79yGIOcOLIEPDRt8GcUdLGc79KA5MWNB857zw003 r6GIV84aPGNpydLfoOsOc15wAd+6cW7V9LWN5t3ECRRTdGxn2enzIL01Q l3HA4jT2SV6igrLXZzxk+cHXqJL4szPPXSgLXC8aLA1Zbroyr9uwReRBF 4SxeeuouEaM6UyNe4aCa2TeYU6kuOF75u7CDByTrWDZL7DciyNOqzf2iy Zo73PaGDAGpVNt9SfhU7ROcpnXTJpW+3ud1sY64vOut2ObW1NmtlBLAUG w==; X-CSE-ConnectionGUID: UHuHdMOHR8eI0Ysd+CRJnQ== X-CSE-MsgGUID: HUOL6jrqQzyh1aS6IVtEsA== X-IronPort-AV: E=Sophos;i="6.12,210,1728943200"; d="scan'208";a="40435227" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 05 Dec 2024 16:22:30 +0100 X-CheckPoint: {6751C536-37-86C05612-CA75E1CA} X-MAIL-CPID: FCDE8C9170E3D42729ED4A0AD7E02C0D_1 X-Control-Analysis: str=0001.0A682F21.6751C537.0039,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 502B6163BB5; Thu, 5 Dec 2024 16:22:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1733412146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OgpqTYmx1JwJV2MXhL2h0e8cSJoFw6QERgxshp0L/wQ=; b=KHXc9JZXoqdeRsEZnWh0P2KoB3nAhvdjG7ZxHhi2Xl3w/sBB5T89MPHE34iZUVvxyoMME5 ML7qUzm+CAyupIe4+o7+jDJrLIt1qwEuKrktHkyz/HRLGYrpKr90X2deBlIp4nR59D5qgh 9pIBOjbeKpl2qtz8QhkW5s8c/O4JeSnWqP52TqhJbvMXOMwl+DeLzMDR0Y4HFiFwC5+3UW BQwCqL82hTsAwk7QhdJXIo1Sx1E/uQml8erg4mGT51+d5GrJY04rFF0gQUg2Sitj6Ma9z4 5ITi7+M3JF6tRYAyJClPpB/liq9cxJjV0ohPX8+1y811NOGP0tVe7b+TgjY1xw== From: Alexander Stein To: Manivannan Sadhasivam , Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Laurent Pinchart , Dave Stevenson Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Dave Stevenson Subject: Re: [PATCH v2 1/4] media: i2c: imx290: Limit analogue gain according to module Date: Thu, 05 Dec 2024 16:22:22 +0100 Message-ID: <4950196.GXAFRqVoOG@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20241120-media-imx290-imx462-v2-1-7e562cf191d8@raspberrypi.com> References: <20241120-media-imx290-imx462-v2-0-7e562cf191d8@raspberrypi.com> <20241120-media-imx290-imx462-v2-1-7e562cf191d8@raspberrypi.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 Hi Dave, Am Mittwoch, 20. November 2024, 20:17:03 CET schrieb Dave Stevenson: > The imx327 only supports up to 29.4dB of analogue gain, vs > the imx290 going up to 30dB. Both are in 0.3dB steps. While I agree for 30dB on imx290, my (maybe outdated) Rev0.2 datasheet says up to 27dB in 0.3dB steps. Despite that this change looks good. Best regards, Alexander > As we now have model specific config, fix this mismatch, > and delete the comment referencing it. >=20 > Signed-off-by: Dave Stevenson > Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/imx290.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > index ee698c99001d..da654deb444a 100644 > --- a/drivers/media/i2c/imx290.c > +++ b/drivers/media/i2c/imx290.c > @@ -176,6 +176,7 @@ struct imx290_model_info { > enum imx290_colour_variant colour_variant; > const struct cci_reg_sequence *init_regs; > size_t init_regs_num; > + unsigned int max_analog_gain; > const char *name; > }; > =20 > @@ -876,14 +877,10 @@ static int imx290_ctrl_init(struct imx290 *imx290) > * up to 72.0dB (240) add further digital gain. Limit the range to > * analog gain only, support for digital gain can be added separately > * if needed. > - * > - * The IMX327 and IMX462 are largely compatible with the IMX290, but > - * have an analog gain range of 0.0dB to 29.4dB and 42dB of digital > - * gain. When support for those sensors gets added to the driver, the > - * gain control should be adjusted accordingly. > */ > v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops, > - V4L2_CID_ANALOGUE_GAIN, 0, 100, 1, 0); > + V4L2_CID_ANALOGUE_GAIN, 0, > + imx290->model->max_analog_gain, 1, 0); > =20 > /* > * Correct range will be determined through imx290_ctrl_update setting > @@ -1441,18 +1438,21 @@ static const struct imx290_model_info imx290_mode= ls[] =3D { > .colour_variant =3D IMX290_VARIANT_COLOUR, > .init_regs =3D imx290_global_init_settings_290, > .init_regs_num =3D ARRAY_SIZE(imx290_global_init_settings_290), > + .max_analog_gain =3D 100, > .name =3D "imx290", > }, > [IMX290_MODEL_IMX290LLR] =3D { > .colour_variant =3D IMX290_VARIANT_MONO, > .init_regs =3D imx290_global_init_settings_290, > .init_regs_num =3D ARRAY_SIZE(imx290_global_init_settings_290), > + .max_analog_gain =3D 100, > .name =3D "imx290", > }, > [IMX290_MODEL_IMX327LQR] =3D { > .colour_variant =3D IMX290_VARIANT_COLOUR, > .init_regs =3D imx290_global_init_settings_327, > .init_regs_num =3D ARRAY_SIZE(imx290_global_init_settings_327), > + .max_analog_gain =3D 98, > .name =3D "imx327", > }, > }; >=20 >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/