* [PATCH] arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5b
@ 2024-10-13 14:30 Cenk Uluisik
0 siblings, 0 replies; 4+ messages in thread
From: Cenk Uluisik @ 2024-10-13 14:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jonas Karlman, Michael Riesch, Andy Yan,
GitAuthor: Cenk Uluisik, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
---
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../boot/dts/rockchip/rk3588s-orangepi-5b.dts | 26 +++++++++++++++++++
2 files changed, 27 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 09423070c992..45249ce15175 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -154,3 +154,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
new file mode 100644
index 000000000000..107b65a5e7ea
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3588s-orangepi-5.dts"
+
+/ {
+ model = "Xunlong Orange Pi 5B";
+ compatible = "rockchip,rk3588s-orangepi-5", "rockchip,rk3588";
+};
+
+&sdhci {
+ status = "okay";
+};
+
+&sfc {
+ status = "disabled";
+};
+
+&wireless_bluetooth {
+ status = "okay";
+};
+
+&wireless_wlan {
+ status = "okay";
+};
--
2.46.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5b
@ 2024-10-13 15:41 Cenk Uluisik
0 siblings, 0 replies; 4+ messages in thread
From: Cenk Uluisik @ 2024-10-13 15:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jonas Karlman, Andy Yan, Michael Riesch,
GitAuthor: Cenk Uluisik, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
Add initial support for OPi5b that includes support for USB2, PCIe2, Sata,
Sdmmc, SPI Flash, PMIC.
---
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../boot/dts/rockchip/rk3588s-orangepi-5b.dts | 26 +++++++++++++++++++
2 files changed, 27 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 09423070c992..45249ce15175 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -154,3 +154,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
new file mode 100644
index 000000000000..107b65a5e7ea
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3588s-orangepi-5.dts"
+
+/ {
+ model = "Xunlong Orange Pi 5B";
+ compatible = "rockchip,rk3588s-orangepi-5", "rockchip,rk3588";
+};
+
+&sdhci {
+ status = "okay";
+};
+
+&sfc {
+ status = "disabled";
+};
+
+&wireless_bluetooth {
+ status = "okay";
+};
+
+&wireless_wlan {
+ status = "okay";
+};
--
2.46.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5b
@ 2024-10-13 15:52 Cenk Uluisik
2024-10-13 18:20 ` Heiko Stübner
0 siblings, 1 reply; 4+ messages in thread
From: Cenk Uluisik @ 2024-10-13 15:52 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jonas Karlman, Andy Yan, Michael Riesch,
Cenk Uluisik, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
Add initial support for OPi5b that includes support for USB2, PCIe2, Sata,
Sdmmc, SPI Flash, PMIC.
Signed-off-by: Cenk Uluisik <cenk.uluisik@googlemail.com>
---
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../boot/dts/rockchip/rk3588s-orangepi-5b.dts | 26 +++++++++++++++++++
2 files changed, 27 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 09423070c992..45249ce15175 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -154,3 +154,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
new file mode 100644
index 000000000000..107b65a5e7ea
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3588s-orangepi-5.dts"
+
+/ {
+ model = "Xunlong Orange Pi 5B";
+ compatible = "rockchip,rk3588s-orangepi-5", "rockchip,rk3588";
+};
+
+&sdhci {
+ status = "okay";
+};
+
+&sfc {
+ status = "disabled";
+};
+
+&wireless_bluetooth {
+ status = "okay";
+};
+
+&wireless_wlan {
+ status = "okay";
+};
--
2.46.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5b
2024-10-13 15:52 [PATCH] arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5b Cenk Uluisik
@ 2024-10-13 18:20 ` Heiko Stübner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2024-10-13 18:20 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chris Morgan,
Jonas Karlman, Andy Yan, Michael Riesch, Cenk Uluisik, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, Cenk Uluisik
Hi,
Am Sonntag, 13. Oktober 2024, 17:52:18 CEST schrieb Cenk Uluisik:
> Add initial support for OPi5b that includes support for USB2, PCIe2, Sata,
> Sdmmc, SPI Flash, PMIC.
Please describe in a better way what actually makes this board different
from the original OrangePi 5.
I.e. it does look like the 5b does have an emmc where the 5 does not.
You also need a separate second patch to update
Documentation/devicetree/bindings/arm/rockchip.yaml
You need to update the Xunlong Orange Pi 5 entry with an enum.
Please see for example the orange-pi-3 entry on how that should look.
> Signed-off-by: Cenk Uluisik <cenk.uluisik@googlemail.com>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3588s-orangepi-5b.dts | 26 +++++++++++++++++++
>
> 2 files changed, 27 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 09423070c992..45249ce15175 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -154,3 +154,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
> new file mode 100644
> index 000000000000..107b65a5e7ea
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
> @@ -0,0 +1,26 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include "rk3588s-orangepi-5.dts"
Please don't include the board dts.
Take a look for example at the rk3566-orangepi-3b on how to do this.
I.e. you want a rk3588s-orangepi-5.dtsi which then gets included
into both the original-5 as well as your 5b .
> +
> +/ {
> + model = "Xunlong Orange Pi 5B";
> + compatible = "rockchip,rk3588s-orangepi-5", "rockchip,rk3588";
> +};
> +
> +&sdhci {
> + status = "okay";
> +};
> +
> +&sfc {
> + status = "disabled";
> +};
> +
> +&wireless_bluetooth {
> + status = "okay";
> +};
> +
> +&wireless_wlan {
> + status = "okay";
> +};
both the wireless_bluetooth as well as the wireless_wlan phandles
are not part of the orange pi 5 in mainline. So this probably doesn't
even compile?
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-13 18:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-13 15:52 [PATCH] arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5b Cenk Uluisik
2024-10-13 18:20 ` Heiko Stübner
-- strict thread matches above, loose matches on Subject: below --
2024-10-13 15:41 Cenk Uluisik
2024-10-13 14:30 Cenk Uluisik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).