[RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

[RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

[Icenowy Zheng]

As there's currently a fork of U-Boot which provides simplefb support
for H3, a simplefb node can be added to the device tree.

Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
---

I'm still not sure which pipeline should I use.

And, it seems that HDMI Slow Clock is not needed?

(seems that it's only for EDID, but simplefb won't use EDID)

 arch/arm/boot/dts/sun8i-h3.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 75a8654..cacc8dd 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi
@@ -50,6 +50,22 @@
 / {
 	interrupt-parent = <&gic>;
 
+	chosen {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		simplefb_hdmi: framebuffer@0 {
+			compatible = "allwinner,simple-framebuffer",
+				     "simple-framebuffer";
+			allwinner,pipeline = "de0-lcd0-hdmi";
+			clocks = <&ccu CLK_BUS_TCON0>, <&ccu CLK_BUS_DE>,
+				 <&ccu CLK_BUS_HDMI>, <&ccu CLK_DE>,
+				 <&ccu CLK_TCON0>, <&ccu CLK_HDMI>;
+			status = "disabled";
+		};
+	};
+
 	cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
-- 
2.10.2

Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

[Chen-Yu Tsai]

On Mon, Nov 28, 2016 at 5:59 PM, Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:
> As there's currently a fork of U-Boot which provides simplefb support

Please add it when its finalized...

> for H3, a simplefb node can be added to the device tree.
>
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> ---
>
> I'm still not sure which pipeline should I use.

You are supposed to add _all_ the pipelines that are available and
supported by U-boot. U-boot is then supposed to enable and update
the one it set up.

ChenYu

>
> And, it seems that HDMI Slow Clock is not needed?
>
> (seems that it's only for EDID, but simplefb won't use EDID)
>
>  arch/arm/boot/dts/sun8i-h3.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index 75a8654..cacc8dd 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -50,6 +50,22 @@
>  / {
>         interrupt-parent = <&gic>;
>
> +       chosen {
> +               #address-cells = <1>;
> +               #size-cells = <1>;
> +               ranges;
> +
> +               simplefb_hdmi: framebuffer@0 {
> +                       compatible = "allwinner,simple-framebuffer",
> +                                    "simple-framebuffer";
> +                       allwinner,pipeline = "de0-lcd0-hdmi";
> +                       clocks = <&ccu CLK_BUS_TCON0>, <&ccu CLK_BUS_DE>,
> +                                <&ccu CLK_BUS_HDMI>, <&ccu CLK_DE>,
> +                                <&ccu CLK_TCON0>, <&ccu CLK_HDMI>;
> +                       status = "disabled";
> +               };
> +       };
> +
>         cpus {
>                 #address-cells = <1>;
>                 #size-cells = <0>;
> --
> 2.10.2
>

Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

[Icenowy Zheng]

28.11.2016, 18:07, "Chen-Yu Tsai" <wens-jdAy2FN1RRM@public.gmane.org>:
> On Mon, Nov 28, 2016 at 5:59 PM, Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:
>>  As there's currently a fork of U-Boot which provides simplefb support
>
> Please add it when its finalized...
>
>>  for H3, a simplefb node can be added to the device tree.
>>
>>  Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
>>  ---
>>
>>  I'm still not sure which pipeline should I use.
>
> You are supposed to add _all_ the pipelines that are available and
> supported by U-boot. U-boot is then supposed to enable and update
> the one it set up.

I mean the pipeline string ;-)

>
> ChenYu
>
>>  And, it seems that HDMI Slow Clock is not needed?
>>
>>  (seems that it's only for EDID, but simplefb won't use EDID)
>>
>>   arch/arm/boot/dts/sun8i-h3.dtsi | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>>  diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
>>  index 75a8654..cacc8dd 100644
>>  --- a/arch/arm/boot/dts/sun8i-h3.dtsi
>>  +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
>>  @@ -50,6 +50,22 @@
>>   / {
>>          interrupt-parent = <&gic>;
>>
>>  + chosen {
>>  + #address-cells = <1>;
>>  + #size-cells = <1>;
>>  + ranges;
>>  +
>>  + simplefb_hdmi: framebuffer@0 {
>>  + compatible = "allwinner,simple-framebuffer",
>>  + "simple-framebuffer";
>>  + allwinner,pipeline = "de0-lcd0-hdmi";
>>  + clocks = <&ccu CLK_BUS_TCON0>, <&ccu CLK_BUS_DE>,
>>  + <&ccu CLK_BUS_HDMI>, <&ccu CLK_DE>,
>>  + <&ccu CLK_TCON0>, <&ccu CLK_HDMI>;
>>  + status = "disabled";
>>  + };
>>  + };
>>  +
>>          cpus {
>>                  #address-cells = <1>;
>>                  #size-cells = <0>;
>>  --
>>  2.10.2

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

[Chen-Yu Tsai]

On Mon, Nov 28, 2016 at 6:19 PM, Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:
>
>
> 28.11.2016, 18:07, "Chen-Yu Tsai" <wens-jdAy2FN1RRM@public.gmane.org>:
>> On Mon, Nov 28, 2016 at 5:59 PM, Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:
>>>  As there's currently a fork of U-Boot which provides simplefb support
>>
>> Please add it when its finalized...
>>
>>>  for H3, a simplefb node can be added to the device tree.
>>>
>>>  Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
>>>  ---
>>>
>>>  I'm still not sure which pipeline should I use.
>>
>> You are supposed to add _all_ the pipelines that are available and
>> supported by U-boot. U-boot is then supposed to enable and update
>> the one it set up.
>
> I mean the pipeline string ;-)

Looks good to me. There's no separate frontend/backend in DE 2.0.

ChenYu

>
>>
>> ChenYu
>>
>>>  And, it seems that HDMI Slow Clock is not needed?
>>>
>>>  (seems that it's only for EDID, but simplefb won't use EDID)
>>>
>>>   arch/arm/boot/dts/sun8i-h3.dtsi | 16 ++++++++++++++++
>>>   1 file changed, 16 insertions(+)
>>>
>>>  diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
>>>  index 75a8654..cacc8dd 100644
>>>  --- a/arch/arm/boot/dts/sun8i-h3.dtsi
>>>  +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
>>>  @@ -50,6 +50,22 @@
>>>   / {
>>>          interrupt-parent = <&gic>;
>>>
>>>  + chosen {
>>>  + #address-cells = <1>;
>>>  + #size-cells = <1>;
>>>  + ranges;
>>>  +
>>>  + simplefb_hdmi: framebuffer@0 {
>>>  + compatible = "allwinner,simple-framebuffer",
>>>  + "simple-framebuffer";
>>>  + allwinner,pipeline = "de0-lcd0-hdmi";
>>>  + clocks = <&ccu CLK_BUS_TCON0>, <&ccu CLK_BUS_DE>,
>>>  + <&ccu CLK_BUS_HDMI>, <&ccu CLK_DE>,
>>>  + <&ccu CLK_TCON0>, <&ccu CLK_HDMI>;
>>>  + status = "disabled";
>>>  + };
>>>  + };
>>>  +
>>>          cpus {
>>>                  #address-cells = <1>;
>>>                  #size-cells = <0>;
>>>  --
>>>  2.10.2
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
> For more options, visit https://groups.google.com/d/optout.

Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

[Jean-Francois Moine]

On Mon, 28 Nov 2016 17:59:00 +0800
Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:

> As there's currently a fork of U-Boot which provides simplefb support
> for H3, a simplefb node can be added to the device tree.
> 
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> ---
> 
> I'm still not sure which pipeline should I use.
> 
> And, it seems that HDMI Slow Clock is not needed?
> 
> (seems that it's only for EDID, but simplefb won't use EDID)

So, I don't see how this may work.
How can the u-boot know the resolutions of the HDMI display device?

In other words: I have a new H3 board with the last u-boot and kernel.
I plug my (rather old or brand new) HDMI display device.
After powering on the system, I hope to get something on the screen.
How?

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

On Mon, Nov 28, 2016 at 06:24:24PM +0800, Chen-Yu Tsai wrote:
> On Mon, Nov 28, 2016 at 6:19 PM, Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:
> >
> >
> > 28.11.2016, 18:07, "Chen-Yu Tsai" <wens-jdAy2FN1RRM@public.gmane.org>:
> >> On Mon, Nov 28, 2016 at 5:59 PM, Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:
> >>>  As there's currently a fork of U-Boot which provides simplefb support
> >>
> >> Please add it when its finalized...
> >>
> >>>  for H3, a simplefb node can be added to the device tree.
> >>>
> >>>  Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> >>>  ---
> >>>
> >>>  I'm still not sure which pipeline should I use.
> >>
> >> You are supposed to add _all_ the pipelines that are available and
> >> supported by U-boot. U-boot is then supposed to enable and update
> >> the one it set up.
> >
> > I mean the pipeline string ;-)
> 
> Looks good to me. There's no separate frontend/backend in DE 2.0.

It looks good to me too.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]

On Mon, Nov 28, 2016 at 11:42:18AM +0100, Jean-Francois Moine wrote:
> On Mon, 28 Nov 2016 17:59:00 +0800
> Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org> wrote:
> 
> > As there's currently a fork of U-Boot which provides simplefb support
> > for H3, a simplefb node can be added to the device tree.
> > 
> > Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> > ---
> > 
> > I'm still not sure which pipeline should I use.
> > 
> > And, it seems that HDMI Slow Clock is not needed?
> > 
> > (seems that it's only for EDID, but simplefb won't use EDID)
> 
> So, I don't see how this may work.
> How can the u-boot know the resolutions of the HDMI display device?
> 
> In other words: I have a new H3 board with the last u-boot and kernel.
> I plug my (rather old or brand new) HDMI display device.
> After powering on the system, I hope to get something on the screen.
> How?

If it works like the driver for the first display engine in U-Boot, it
will use the preferred mode reported by the EDID, and will fallback to
1024x768 if it cannot access it.

Maybe it would be worth exchanging on the EDID code that has been done
for the u-boot driver too, so that it can be fixed in your driver.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

[Jean-Francois Moine]

On Tue, 29 Nov 2016 22:59:32 +0100
Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> > > I'm still not sure which pipeline should I use.
> > > 
> > > And, it seems that HDMI Slow Clock is not needed?
> > > 
> > > (seems that it's only for EDID, but simplefb won't use EDID)
> > 
> > So, I don't see how this may work.
> > How can the u-boot know the resolutions of the HDMI display device?
> > 
> > In other words: I have a new H3 board with the last u-boot and kernel.
> > I plug my (rather old or brand new) HDMI display device.
> > After powering on the system, I hope to get something on the screen.
> > How?
> 
> If it works like the driver for the first display engine in U-Boot, it
> will use the preferred mode reported by the EDID, and will fallback to
> 1024x768 if it cannot access it.

Icenowy wrote: "simplefb won't use EDID"

Then, if it is like in the kernel, the 1024x768 mode is VGA. It does
not work with HDMI (different timings).

> Maybe it would be worth exchanging on the EDID code that has been done
> for the u-boot driver too, so that it can be fixed in your driver.

The u-boot got my code, and, up to now, I could not fix the random or
permanent failures of EDID reading in some boards.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

[Jernej Skrabec]

[-- Attachment #1.1: Type: text/plain, Size: 2662 bytes --]

Hi Jean-François,

Dne sreda, 30. november 2016 10.35.08 UTC+1 je oseba Jean-François Moine 
napisala:
>
> On Tue, 29 Nov 2016 22:59:32 +0100 
> Maxime Ripard <maxime...-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org <javascript:>> wrote: 
>
> > > > I'm still not sure which pipeline should I use. 
> > > > 
> > > > And, it seems that HDMI Slow Clock is not needed? 
> > > > 
> > > > (seems that it's only for EDID, but simplefb won't use EDID) 
> > > 
> > > So, I don't see how this may work. 
> > > How can the u-boot know the resolutions of the HDMI display device? 
> > > 
> > > In other words: I have a new H3 board with the last u-boot and kernel. 
> > > I plug my (rather old or brand new) HDMI display device. 
> > > After powering on the system, I hope to get something on the screen. 
> > > How? 
> > 
> > If it works like the driver for the first display engine in U-Boot, it 
> > will use the preferred mode reported by the EDID, and will fallback to 
> > 1024x768 if it cannot access it. 
>
> Icenowy wrote: "simplefb won't use EDID" 
>
> Then, if it is like in the kernel, the 1024x768 mode is VGA. It does 
> not work with HDMI (different timings). 
>

U-Boot driver now accept any timings recommended by EDID. So far it
was tested with at least following resolutions:
- 1920x1080 @ 60 Hz
- 1280x1024 @ 60 Hz
- 1280x800 @ 60 Hz (slight clock difference)
- 800x480 (not sure about frame rate)
- 3840x2160 @ 30 Hz (4K)

and nobody complained so far. I'm pretty sure 1024x768 would work.


> > Maybe it would be worth exchanging on the EDID code that has been done 
> > for the u-boot driver too, so that it can be fixed in your driver. 
>
> The u-boot got my code, and, up to now, I could not fix the random or 
> permanent failures of EDID reading in some boards. 
>
>
I only have one OPi2, but as I said, EDID always worked for me. The only
code left from you is for DE2. HDMI stuff is basically copied from Rockhip
driver (including EDID reading), TCON code is now reverted to the same as
it is in sunxi_display.c. I think it is worth to take a look at EDID code 
and
compare it.
 

> -- 
> Ken ar c'hentañ        |              ** Breizh ha Linux atav! ** 
> Jef                |                http://moinejf.free.fr/


Best regards,
Jernej Škrabec 

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #1.2: Type: text/html, Size: 4177 bytes --]