From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1454F17BEC5 for ; Wed, 9 Oct 2024 07:19:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728458375; cv=none; b=K695OitjEk+5s1r5G6H2P3ATqy/2UyphNwcq4ELYwnjvZj9x65agze2VUgSsi0X1mvjUILVOz9FDdxEpMpcF6Mu1OuVE/MnzsVp7bv7KbNOS3JvUh2lp/2cQMlLTCddotiP8OxA5uQm28ChN6ojMC6oprdYe7EimQZiwF6hh5Bk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728458375; c=relaxed/simple; bh=IKEypxdnTVBpWaRajhN1OoYVA8LV6cDM3jxDv2ONDlc=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=SyhChdLW2CcXmd1ecK4bDMQZeHlp5ygelnicBNEORkK7eSXu/qFZc8HA9mbN740TK0SRLEzGDcEvE18lyh2oppGiyrrO6lBxfSfRDSjw4o5pFCQc5w2gNQtWQinoViUscr4wjivBlJgwWKwCzdMVuY14opeJpF2cL+m2+CYjvLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=S1glFR5e; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="S1glFR5e" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1728458370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vq2LQakHupliHJ2gUTGDwZanhNGh8YhnFZHow8lZa2M=; b=S1glFR5ee1zNLWcC3D27TXWG7B16P1OKncIDe4ADX4pZ8Kyhzcbzhf5f2jyYYMQD7YSj2v Z2OZ+oB9Kx2uBTRYmY2L7QWig91dt5VF/klXaye0hwm3s6IDsUoRREmptd0v4pQUPLR8k3 cN4fMzdF7IvEYjGa3/Qw5QPjtRhdPwrcdxeeuI8ZyvPX48hXVD7x28Xs07bDHAASm+0Ixt Z0OXJNEH42guHDEmhRnKWSkuAsKlN0E4BWBuTpv03mlC3C7Xyel4jqfWLDf8JM9sKotYsV lByCrQ+aZb0VmZv08nzWhivf7RlH1OuVJjABpTUfEwaWCsNtSkRJDqZluQpO/w== Date: Wed, 09 Oct 2024 09:19:30 +0200 From: Dragan Simic To: Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Andy Yan Subject: Re: [PATCH v2 07/14] arm64: dts: rockchip: Fix LED triggers on rk3308-roc-cc In-Reply-To: <20241008203940.2573684-8-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> <20241008203940.2573684-8-heiko@sntech.de> Message-ID: <4964eb8c49c1ad6620f965d479a7d37b@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Hello Heiko, On 2024-10-08 22:39, Heiko Stuebner wrote: > There are two LEDs on the board, power and user events. > Currently both are assigned undocumented IR(-remote) > triggers that are probably only part of the vendor-kernel. > > To make dtbs check happier, assign the power-led to a generic > default-on trigger and the user led to the documented rc-feedback > trigger that should mostly match its current usage. > > Fixes: 4403e1237be3 ("arm64: dts: rockchip: Add devicetree for board > roc-rk3308-cc") > Cc: Andy Yan > Signed-off-by: Heiko Stuebner Looking rather meh to me, but I guess that's as good as it gets. Thanks for the patch. Reviewed-by: Dragan Simic > --- > arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > index 9232357f4fec..d9e191ad1d77 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3308-roc-cc.dts > @@ -36,14 +36,14 @@ leds { > > power_led: led-0 { > label = "firefly:red:power"; > - linux,default-trigger = "ir-power-click"; > + linux,default-trigger = "default-on"; > default-state = "on"; > gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>; > }; > > user_led: led-1 { > label = "firefly:blue:user"; > - linux,default-trigger = "ir-user-click"; > + linux,default-trigger = "rc-feedback"; > default-state = "off"; > gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_HIGH>; > };