Re: [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings

Heiko Stübner
2025-05-06T16:38:36Z

Hi John,

Am Dienstag, 6. Mai 2025, 17:54:10 Mitteleuropäische Sommerzeit schrieb John Clark:
> On 5/6/25 11:44 AM, Conor Dooley wrote:
> > On Tue, May 06, 2025 at 07:41:14AM -0400, John Clark wrote:
> >> Add device tree binding for the Luckfox Omni3576 Carrier Board with
> >> Core3576 Module, based on the Rockchip RK3576 SoC.
> >>
> >> Signed-off-by: John Clark <inindev@gmail.com>
> >> ---
> >> Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
> >> 1 file changed, 10 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> index 455fbb290b77..826dede32145 100644
> >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> @@ -715,6 +715,16 @@ properties:
> >> - const: lckfb,tspi-rk3566
> >> - const: rockchip,rk3566
> >>
> >> + - description: Luckfox Core3576 Module
> >> + items:
> >> + - const: luckfox,core3576
> >> + - const: rockchip,rk3576
> >> +
> >> + - description: Luckfox Omni3576 Carrier Board
> >> + items:
> >> + - const: luckfox,omni3576
> >> + - const: rockchip,rk3576
> >
> > Not sure this is correct, does the module not have to be attached to
> > this particular carrier to be used?
>
> The compute module and the carrier board together like the E25.
> Presumably the compute module would be used in other applications
> but the carrier board is not useful without it.
>
> Is the E25 done correctly here? I can copy this format:

For the baseboard + module you should always have one of those

> >> + - description: Luckfox Core3576 Module
> >> + items:
> >> + - const: luckfox,core3576
> >> + - const: rockchip,rk3576
> >> +

- description: Luckfox Core3576 based boards
items:
- enum:
- luckfox,omni3576
- const: luckfox,core3576
- const: rockchip,rk3576

I've looked at the product page [0] now and the Core3576 module itself
can't work independently without a baseboard present, so the above should
be enough, and also allows for possible future other baseboards to be
integrated.

Heiko

[0] https://www.luckfox.com/EN-Core3576