Re: [PATCH v3 2/3] dt-bindings: arm: rockchip: Add Luckfox Omni3576 and Core3576 bindings

Conor Dooley
2025-05-06T15:44:54Z

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

On Tue, May 06, 2025 at 07:41:14AM -0400, John Clark wrote:
> Add device tree binding for the Luckfox Omni3576 Carrier Board with
> Core3576 Module, based on the Rockchip RK3576 SoC.
>
> Signed-off-by: John Clark <inindev@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 455fbb290b77..826dede32145 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -715,6 +715,16 @@ properties:
> - const: lckfb,tspi-rk3566
> - const: rockchip,rk3566
>
> + - description: Luckfox Core3576 Module
> + items:
> + - const: luckfox,core3576
> + - const: rockchip,rk3576
> +
> + - description: Luckfox Omni3576 Carrier Board
> + items:
> + - const: luckfox,omni3576
> + - const: rockchip,rk3576

Not sure this is correct, does the module not have to be attached to
this particular carrier to be used?

> +
> - description: Lunzn FastRhino R66S / R68S
> items:
> - enum:
> --
> 2.39.5
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]