devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	agross@kernel.org, andersson@kernel.org, lumag@kernel.org,
	dmitry.baryshkov@oss.qualcomm.com, konradybcio@kernel.org,
	daniel.lezcano@linaro.org, sboyd@kernel.org, amitk@kernel.org,
	thara.gopinath@gmail.com, lee@kernel.org, rafael@kernel.org,
	subbaraman.narayanamurthy@oss.qualcomm.com,
	david.collins@oss.qualcomm.com,
	anjelique.melendez@oss.qualcomm.com,
	kamal.wadhwa@oss.qualcomm.com, rui.zhang@intel.com,
	lukasz.luba@arm.com, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	cros-qcom-dts-watchers@chromium.org, quic_kotarake@quicinc.com,
	neil.armstrong@linaro.org, stephan.gerhold@linaro.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH V7 3/5] dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen3 ADC
Date: Mon, 20 Oct 2025 17:55:27 +0200	[thread overview]
Message-ID: <4979bd26-0a77-4390-9db2-6d40cd7f963c@kernel.org> (raw)
In-Reply-To: <3a32746a-5b0e-4c0a-8322-00cd3a84394a@oss.qualcomm.com>

On 20/10/2025 14:51, Konrad Dybcio wrote:
> On 10/17/25 3:40 PM, Krzysztof Kozlowski wrote:
>> On 17/10/2025 13:18, Jishnu Prakash wrote:
>>> Hi Krzysztof,
>>>
>>> On 10/9/2025 5:22 AM, Krzysztof Kozlowski wrote:
>>>> On 08/10/2025 23:20, Jishnu Prakash wrote:
>>>>> Hi Krzysztof,
>>>>>
>>>>> On 10/4/2025 12:22 PM, Krzysztof Kozlowski wrote:
>>>>>> On Sat, 4 Oct 2025 at 11:42, Jishnu Prakash
>>>>>> <jishnu.prakash@oss.qualcomm.com> wrote:
>>>>>>>
>>>>>>> Hi Jonathan,
>>>>>>>
>>>>>>> On 9/27/2025 7:17 PM, Jonathan Cameron wrote:
>>>>>>>> On Fri, 19 Sep 2025 20:17:43 +0530
>>>>>>>> Jishnu Prakash <jishnu.prakash@oss.qualcomm.com> wrote:
> 
> [...]
> 
>>> Can you please provide your suggestions on changes we can make
>>> in the above points ?
>>
>> You just pasted DT. I asked about SW, software. Please read carefully
>> previous comments.
> 
> Is the problem that Jishnu included some indices in dt-bindings without
> also adding them in the driver's adc5_gen3_chans_pmic[] array?
> 
> As in, would the resolution to this thread be simply handling all of
> them in the driver correctly?

The solution is to remove them from the bindings, just like we do with
many other hardware constants. Of course if these are not hardware
constants, but part of ABI, then solution would be different but no one
provided proof or argument that this is any binding. All proofs were
"but I want to use it in my DTS", which proofs nothing. Not a binding.

While this issue is not that important, we keep discussing it because
author does not try to understand the problem or even keep up the
discussion. Instead repeats the same without really reading my
messages... and then disappears for month or more.

Best regards,
Krzysztof

  reply	other threads:[~2025-10-20 15:55 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26  8:36 [PATCH V7 0/5] Add support for QCOM SPMI PMIC5 Gen3 ADC Jishnu Prakash
2025-08-26  8:36 ` [PATCH V7 1/5] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder Jishnu Prakash
2025-08-26  8:36 ` [PATCH V7 2/5] dt-bindings: iio: adc: Split out QCOM VADC channel properties Jishnu Prakash
2025-08-26  8:36 ` [PATCH V7 3/5] dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen3 ADC Jishnu Prakash
2025-08-29  7:19   ` Krzysztof Kozlowski
2025-09-16 14:28     ` Jishnu Prakash
2025-09-17  0:29       ` Krzysztof Kozlowski
2025-09-17 19:47         ` Jishnu Prakash
2025-09-18  0:15           ` Krzysztof Kozlowski
2025-09-19 14:47             ` Jishnu Prakash
2025-09-27 13:47               ` Jonathan Cameron
2025-10-04  2:41                 ` Jishnu Prakash
2025-10-04  6:52                   ` Krzysztof Kozlowski
2025-10-08 14:20                     ` Jishnu Prakash
2025-10-08 23:52                       ` Krzysztof Kozlowski
2025-10-17 11:18                         ` Jishnu Prakash
2025-10-17 13:40                           ` Krzysztof Kozlowski
2025-10-20 12:51                             ` Konrad Dybcio
2025-10-20 15:55                               ` Krzysztof Kozlowski [this message]
2025-10-22 11:02                                 ` Konrad Dybcio
2025-10-27 16:30                                   ` Krzysztof Kozlowski
2025-11-01  2:20                                     ` Jishnu Prakash
2025-08-26  8:36 ` [PATCH V7 4/5] " Jishnu Prakash
2025-08-30 17:42   ` Jonathan Cameron
2025-09-17 19:47     ` Jishnu Prakash
2025-08-26  8:36 ` [PATCH V7 5/5] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring Jishnu Prakash
2025-08-27  1:44   ` Dmitry Baryshkov
2025-08-29  7:14   ` Krzysztof Kozlowski
2025-08-30 17:58   ` Jonathan Cameron
2025-09-17 19:47     ` Jishnu Prakash
2025-08-29  7:11 ` [PATCH V7 0/5] Add support for QCOM SPMI PMIC5 Gen3 ADC Krzysztof Kozlowski
2025-09-16 14:27   ` Jishnu Prakash
2025-08-29  7:12 ` Krzysztof Kozlowski
2025-08-29  8:09   ` Dmitry Baryshkov
2025-08-29  9:11     ` Krzysztof Kozlowski
2025-08-29  9:20       ` Dmitry Baryshkov
2025-08-29 16:31         ` Jonathan Cameron
2025-09-17 19:43           ` Bjorn Andersson
2025-09-19 14:47             ` Jishnu Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4979bd26-0a77-4390-9db2-6d40cd7f963c@kernel.org \
    --to=krzk@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=agross@kernel.org \
    --cc=amitk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=anjelique.melendez@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=david.collins@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=jic23@kernel.org \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=lumag@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_kotarake@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sboyd@kernel.org \
    --cc=stephan.gerhold@linaro.org \
    --cc=subbaraman.narayanamurthy@oss.qualcomm.com \
    --cc=thara.gopinath@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).