From: Prasanna Vengateshan <prasanna.vengateshan@microchip.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <andrew@lunn.ch>, <netdev@vger.kernel.org>, <olteanv@gmail.com>,
<robh+dt@kernel.org>, <UNGLinuxDriver@microchip.com>,
<Woojung.Huh@microchip.com>, <hkallweit1@gmail.com>,
<linux@armlinux.org.uk>, <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <vivien.didelot@gmail.com>,
<f.fainelli@gmail.com>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v7 net-next 07/10] net: dsa: microchip: add support for ethtool port counters
Date: Mon, 7 Feb 2022 22:33:25 +0530 [thread overview]
Message-ID: <49878826c61a9fe556869710fecee615cf2a0c21.camel@microchip.com> (raw)
In-Reply-To: <20220204192721.21835705@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, 2022-02-04 at 19:27 -0800, Jakub Kicinski wrote:
> > + for (i = 0; i < dev->mib_cnt; i++) {
> > + memcpy(buf + i * ETH_GSTRING_LEN, lan937x_mib_names[i].string,
> > + ETH_GSTRING_LEN);
> > + }
>
> parenthesis unnecessary around single expression
>
> Also check out ethtool_sprintf(), although not strictly necessary since
> you're not formatting
Sure, thanks for the feedback.
Prasanna V
next prev parent reply other threads:[~2022-02-07 17:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 17:44 [PATCH v7 net-next 00/10] net: dsa: microchip: DSA driver support for LAN937x switch Prasanna Vengateshan
2022-02-04 17:44 ` [PATCH v7 net-next 01/10] dt-bindings: net: dsa: dt bindings for microchip lan937x Prasanna Vengateshan
2022-02-04 22:11 ` Rob Herring
2022-02-04 17:44 ` [PATCH v7 net-next 02/10] net: dsa: move mib->cnt_ptr reset code to ksz_common.c Prasanna Vengateshan
2022-02-04 17:44 ` [PATCH v7 net-next 03/10] net: phy: Add support for LAN937x T1 phy driver Prasanna Vengateshan
2022-02-04 17:44 ` [PATCH v7 net-next 04/10] net: dsa: tag_ksz: add tag handling for Microchip LAN937x Prasanna Vengateshan
2022-02-04 17:44 ` [PATCH v7 net-next 05/10] net: dsa: microchip: add DSA support for microchip lan937x Prasanna Vengateshan
2022-02-05 3:27 ` Jakub Kicinski
2022-02-04 17:44 ` [PATCH v7 net-next 06/10] net: dsa: microchip: add support for phylink management Prasanna Vengateshan
2022-02-04 18:14 ` Russell King (Oracle)
2022-02-07 16:58 ` Prasanna Vengateshan
2022-02-04 17:44 ` [PATCH v7 net-next 07/10] net: dsa: microchip: add support for ethtool port counters Prasanna Vengateshan
2022-02-05 3:27 ` Jakub Kicinski
2022-02-07 17:03 ` Prasanna Vengateshan [this message]
2022-02-04 17:44 ` [PATCH v7 net-next 08/10] net: dsa: microchip: add support for port mirror operations Prasanna Vengateshan
2022-02-04 17:44 ` [PATCH v7 net-next 09/10] net: dsa: microchip: add support for fdb and mdb management Prasanna Vengateshan
2022-02-04 17:45 ` [PATCH v7 net-next 10/10] net: dsa: microchip: add support for vlan operations Prasanna Vengateshan
2022-02-05 3:29 ` [PATCH v7 net-next 00/10] net: dsa: microchip: DSA driver support for LAN937x switch Jakub Kicinski
2022-02-07 14:01 ` Prasanna Vengateshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49878826c61a9fe556869710fecee615cf2a0c21.camel@microchip.com \
--to=prasanna.vengateshan@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).