From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C572C38A02 for ; Fri, 28 Oct 2022 19:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbiJ1Trg (ORCPT ); Fri, 28 Oct 2022 15:47:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbiJ1Trf (ORCPT ); Fri, 28 Oct 2022 15:47:35 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E15A8241B08 for ; Fri, 28 Oct 2022 12:47:33 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id r19so4133675qtx.6 for ; Fri, 28 Oct 2022 12:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SuLQ4LGhTb9iEJLwlybh7NzL9tVrunJow2oZoFj99dQ=; b=Pjxp64dtv0DecR/RobHlhnBssFPkJpiIYdP9pzvHpW8KX1urKw17Q3/hVzO6xZuWU0 ZEBP7vT3vkOpmYLoHdriGyrmvzZ7BkZmOWgPP3PV7bczMOcHweuS0/lffViCJIt/zuTh GQvoM9yVvq8QtBvga4RIfbp7cvVeoRvDUlevsM7b1/SnTgFsY/w9vPdcH/utytuS3kty Kx7tCElNtSa8/P9Rxw0cqhW4GGO0QGqALG5Zca8cMOvmrsjNKC7wqSTPQinjgA5BZ49S VYzbWWiza4Z/UtvQt2tUN89m0uFwB8WeQwLBW7M9W2qD4bih9ojfGr/pBjHHrpNO1ygV S4+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SuLQ4LGhTb9iEJLwlybh7NzL9tVrunJow2oZoFj99dQ=; b=LuPF16+TxY97grHLpjyNVzvPc2X4Vrs8Q6A5iRosjQ6TVqgOEOZ4kWPbOPZVkVDPox QrFlvU59mP2m3CbOZAH6ms3KvTrXnHorpuI3zA1vbQm9CHkbYMPwTsQlUZOu/gckr5j3 2o/ipzxdesjUSKdkvG6QVy5fpwE+uFXqOcgC+QmQV7V8+OBJYQ94/U6vWjXyJ+n1ybfd XSEV8XNyPBKjsiX9xckzOYGnfqgffDwsCB3zioC88vgKTGSU1BK/iS7M/jouEVS26WxZ si26UGzfGQ4GDwB9OtG1KrkT56qW6Kpu9TeRuAPvP7xYB8iiZ4hcOGdRwc95/3kzuZxt BXAg== X-Gm-Message-State: ACrzQf0ljJSmYF3ZBBV7DbrWvD0K+qovFMxkyCuQDxlwJv+F+KD8yoYD efvLkeusTDSocMi736DLAGJrCg== X-Google-Smtp-Source: AMsMyM6lrikoLcv6eLHGa7lpzNLbaHvBXJP/FuXl58MVeVcQpzV+fNRBVO9OTj27uH/gzSL/lvnmwQ== X-Received: by 2002:ac8:5b81:0:b0:39c:b735:6b8b with SMTP id a1-20020ac85b81000000b0039cb7356b8bmr1011547qta.416.1666986453067; Fri, 28 Oct 2022 12:47:33 -0700 (PDT) Received: from [192.168.1.11] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id h24-20020ac85498000000b00399b73d06f0sm2842518qtq.38.2022.10.28.12.47.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 12:47:32 -0700 (PDT) Message-ID: <498e6e3a-6391-c220-f7db-211aa415dde8@linaro.org> Date: Fri, 28 Oct 2022 15:47:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/4] dt-bindings: pwm: Add Apple PWM controller Content-Language: en-US To: Sasha Finkelstein , thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221028165215.43662-1-fnkl.kernel@gmail.com> <20221028165215.43662-2-fnkl.kernel@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221028165215.43662-2-fnkl.kernel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/10/2022 12:52, Sasha Finkelstein wrote: > Apple SoCs such as the M1 contain a PWM controller used > among other things to control the keyboard backlight. > > Signed-off-by: Sasha Finkelstein > --- > .../devicetree/bindings/pwm/pwm-apple.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-apple.yaml b/Documentation/devicetree/bindings/pwm/pwm-apple.yaml > new file mode 100644 > index 000000000000..39dc32e00a3f > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-apple.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/pwm-apple.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple FPWM controller > + > +maintainers: > + - asahi@lists.linux.dev > + - Sasha Finkelstein > + > +description: |+ > + PWM controller used for keyboard backlight on ARM Macs > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t8103-fpwm > + - apple,t6000-fpwm > + - apple,t8112-fpwm > + - const: apple,s5l-fpwm Missing blank line. > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + "#pwm-cells": > + const: 2 > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + pwm: fpwm@235044000 { > + compatible = "apple,s5l-fpwm"; As Rob's bot pointed out, this does not match the bindings so you did not test them before sending :( Best regards, Krzysztof