From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH 6/8] --- arch/powerpc/boot/dts/socrates.dts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) Date: Wed, 01 Apr 2009 09:31:34 +0200 Message-ID: <49D31856.9060808@grandegger.com> References: <20090331123727.853787299@denx.de> <20090331124036.057237866@denx.de> <20090331230451.GA23304@yookeroo.seuss> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090331230451.GA23304@yookeroo.seuss> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@ozlabs.org To: Wolfgang Grandegger , linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org List-Id: devicetree@vger.kernel.org Hi David, this patch went out by mistake, sorry. David Gibson wrote: > On Tue, Mar 31, 2009 at 02:37:33PM +0200, Wolfgang Grandegger wrote: >> Index: linux-2.6/arch/powerpc/boot/dts/socrates.dts >> =================================================================== >> --- linux-2.6.orig/arch/powerpc/boot/dts/socrates.dts 2009-03-31 13:24:38.078719288 +0200 >> +++ linux-2.6/arch/powerpc/boot/dts/socrates.dts 2009-03-31 13:47:56.986720719 +0200 >> @@ -52,6 +52,7 @@ >> soc8544@e0000000 { >> #address-cells = <1>; >> #size-cells = <1>; >> + device_type = "soc"; > > You should not be adding device_type to a new board's dts. You > *especially* shouldn't be doing that with no patch comment explaining > why. In the final patch I have removed the device_type = "soc", but it makes trouble as some mpc85xx rely on it. Removing it would also break U-Boot compatibility. Is it worth that? The issue is discussed on the thread http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070020.html. Wolfgang.