From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 875D7C77B73 for ; Tue, 6 Jun 2023 11:14:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232637AbjFFLO0 (ORCPT ); Tue, 6 Jun 2023 07:14:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232926AbjFFLOZ (ORCPT ); Tue, 6 Jun 2023 07:14:25 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A59C5E40 for ; Tue, 6 Jun 2023 04:14:23 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-970056276acso884678666b.2 for ; Tue, 06 Jun 2023 04:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686050062; x=1688642062; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lZSmA8DY0eTLKSTs9zFUI42k53ST/DbB3g3jLk/VVH4=; b=rCaOS62Yrkxmzf8yxhctHVMGqbGEnvBbPAPUum2pPYYLMqQ16bKL7AcLgocA1/0Lec jcBSGmJ/YMduP30NT0m33MVzOgohuUQxM22FbiVRT5+KBSqpeZb01zlIiD3amv5cewKF HNo+uOfiN1lOJjmKumu1r2ABFRFtTazGXI2OuBTMl+vMoUPy18+pcQaQqlJIqc21no4D /mdFcxLbSIpqfM5gL7K9RQn+KNyU5KP6wBOdpgTwtAbx+P1IETZi341c4Vortt5X5Y5O mcNJu2XF/X1JpLT+dzDDJ997Db+0z1jgnPOQMrsTh1CVNRugZGQf4L7oxpcDky4jH8iI 3jtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686050062; x=1688642062; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lZSmA8DY0eTLKSTs9zFUI42k53ST/DbB3g3jLk/VVH4=; b=UP0+QXAwq4CcHy7dYZZxCD0FHvgMWRIf714UosdqeN01CpiEySCIzLQJTslrOxMxSk UmUIEC6W8o2wRrRBx0+XE6bi///gBvrl5G5IVrTVXSHfC4RSTPi+9dUA5pJTd6u+4LPY JL7cMuaAnWoqLVt0dZfQM23xzxDIq2wX2UHCUalfoklfM3p2P+mC9n0gi+QGrKYnvWSO /0FAczAggXnSDN+nerXJ5xfT0BFNuP+/dtsblX8n39DTrbXYO3k156pbef9nfzoFmQ21 k/u4a0HGlTYx12TLqa/JsQXBCTNQzTs9XpJBGdzITqMujix/W6Y057q3bR0fUI1JNqGE gNBw== X-Gm-Message-State: AC+VfDxmqxrxN8/5wGW+rZqf6SzeWr9ji+O0+ZQ6jkSzRztdQ6R/j+3U TmIPL4hpqBLjewTbgGA3JNKYYw== X-Google-Smtp-Source: ACHHUZ7Te2mWiSqGZNgHvL+5bOOq01EPLyHtb7WGfPbOM1p4qruYTL10yBMBpLJ3aF5t8VoUPsjUQQ== X-Received: by 2002:a17:907:3f8f:b0:969:f54c:dee2 with SMTP id hr15-20020a1709073f8f00b00969f54cdee2mr2171446ejc.26.1686050062111; Tue, 06 Jun 2023 04:14:22 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id o18-20020a170906601200b0096f71ace804sm5463236ejj.99.2023.06.06.04.14.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jun 2023 04:14:21 -0700 (PDT) Message-ID: <49a33caf-e310-fcfb-7786-6731dcc747f5@linaro.org> Date: Tue, 6 Jun 2023 13:14:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v8 3/3] dt-bindings: mtd: marvell-nand: Convert to YAML DT scheme Content-Language: en-US From: Krzysztof Kozlowski To: Miquel Raynal Cc: Chris Packham , "richard@nod.at" , "vigneshr@ti.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "andrew@lunn.ch" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" , "conor@kernel.org" , "linux-mtd@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "enachman@marvell.com" , Vadym Kochan References: <20230531234923.2307013-1-chris.packham@alliedtelesis.co.nz> <20230531234923.2307013-4-chris.packham@alliedtelesis.co.nz> <785368df-1881-e62e-6172-d902cee814a8@alliedtelesis.co.nz> <4ea0b16e-0cec-00db-c598-e0364a7edef8@alliedtelesis.co.nz> <9fc57052-5049-ed50-ca95-cfd1d0420dd9@alliedtelesis.co.nz> <20230606094855.1ab005eb@xps-13> <845924ba-d9bf-d0ec-e1f2-f721366f43c0@linaro.org> <20230606122812.411b223a@xps-13> <20230606125724.126a4685@xps-13> <20230606130719.5350174c@xps-13> <037f5455-35c1-e13d-814c-16317a2a15f3@linaro.org> In-Reply-To: <037f5455-35c1-e13d-814c-16317a2a15f3@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/06/2023 13:11, Krzysztof Kozlowski wrote: >>> If yes, please ignore the series sent aside, I will work on it again >>> and send a v2. >> >> Actually I already see a problem, let's the ingenic,nand.yaml example. >> The goal, IIUC, is to do: >> >> patternProperties: >> "^nand@[a-f0-9]$": >> type: object >> + $ref: nand-chip.yaml >> properties: >> >> ... >> >> + unevaluatedProperties: false >> >> The example in this file uses a property, nand-on-flash-bbt, which is >> described inside nand-controller.yaml instead of nand-chip.yaml. >> Indeed, the former actually describes many properties which are a bit >> more controller related than chip related. With the above description, >> the example fails because nand-on-flash-bbt is not allowed (it is not >> listed in nand-chip.yaml). >> >> How would you proceed in this case? >> >> Maybe I could move all the NAND chip properties which are somehow >> related to NAND controllers (and defined in nand-controller.yaml) in a >> dedicated file and reference it from nand-chip.yaml? Any other idea is >> welcome. > > Yes, this would work and seems reasonable. Actually, since nand-chip is used by both SPI and NAND, then I think better would be to create separate file - nand-only-chip.yaml (name to be discussed): nand-controller.yaml: "^nand@[a-f0-9]$": $ref: nand-only-chip.yaml nand-only-chip.yaml: $ref: nand-chip.yaml all nand-controller-chip properties follow > Other way could be to add > unevaluatedProperties:false on this level (so after ref:nand-chip.yaml) > in nand-controller.yaml. This however would not allow any new properties > to be defined in device bindings. Best regards, Krzysztof